feat(usb): embed refreshed per-board VID:PID archive, drop hardcoded table (#722)#1013
Conversation
…table (#722) The per-vendor VID:PID ingest sub-issues (#723–#740) are all closed, so the FastLED/boards pipeline now carries far richer per-board data than fbuild's stale 745-byte embedded proto. Regenerate `usb-vids.proto.zstd` from the current boards data (745 B → 10 KB, 36 VIDs / 1369 PID rows) so offline resolution names real boards/probes instead of `Device 0xPPPP` placeholders: 303A:1001 → WEMOS LOLIN S3 1FC9:0132 → NXP LPC-Link2 (CMSIS-DAP) 1FC9:0143 → NXP MCU-Link 16C0:0483 → Teensy 4.0 Curated on the boards `other` branch (FastLED/boards#44): added the MCU-Link PID (1fc9:0143) and authoritative vendor overrides for shared UART-bridge VIDs that the board-attribution pipeline otherwise mislabels (10c4 Silicon Labs, 0403 FTDI, 1a86 QinHeng/WCH, 067b Prolific — previously Arduino/Digilent/OLIMEX). Delete the hardcoded `FRIENDLY_PRODUCTS` supplement table from `port_scan`: friendly product names are now owned by the boards VID:PID data and embedded at build time. A missing name is a boards-data gap, not an fbuild source edit. Verified offline on real hardware: `port scan --offline` shows `Silicon Labs / …`, `NXP LPC-Link2 …`, `PJRC (Teensy) / Teensy 4.0`, `Espressif Systems / WEMOS LOLIN S3` with no network and no hardcoded table. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 1 minute Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #722. (All per-vendor ingest sub-issues #723–#740 are already closed; this lands the fbuild-facing embedding + removes the last hardcoded table.)
What
usb-vids.proto.zstdfrom the current FastLED/boards pipeline: 745 B → 10 KB, 36 VIDs / 1369 PID rows. Offline resolution now names real boards/probes instead ofDevice 0xPPPP.FRIENDLY_PRODUCTStable inport_scan— product names are owned by the boards VID:PID data, embedded at build time (per follow up all known vids needs built in embedding #959's build-time-embedding direction). A missing name is a boards-data gap, not an fbuild edit.1fc9:0143and authoritative vendor overrides for shared UART-bridge VIDs the board-attribution pipeline mislabels (10c4→Silicon Labs,0403→FTDI,1a86→QinHeng/WCH,067b→Prolific — were Arduino/Digilent/OLIMEX).Verified offline (real hardware)
fbuild port scan --offline:Tests: fbuild-core usb (22) + port_scan (16) green; clippy + fmt clean.
🤖 Generated with Claude Code