Skip to content

fix(rp2040): explain Windows synthetic volume errors#1066

Merged
zackees merged 1 commit into
mainfrom
fix/rp2040-windows-volume-diagnostic
Jul 15, 2026
Merged

fix(rp2040): explain Windows synthetic volume errors#1066
zackees merged 1 commit into
mainfrom
fix/rp2040-windows-volume-diagnostic

Conversation

@zackees

@zackees zackees commented Jul 15, 2026

Copy link
Copy Markdown
Member

Summary

  • classify Windows error 1392 from the RP-series BOOTSEL synthetic FAT volume
  • preserve the original copy error while explicitly warning against chkdsk, repair, or formatting
  • direct users to reconnect or use fbuild's managed picotool fallback with the documented WinUSB binding

Validation

  • soldr cargo fmt --all -- --check
  • soldr cargo test -p fbuild-deploy rp2040 (27 passed)
  • soldr cargo clippy -p fbuild-deploy --all-targets -- -D warnings (passes; existing MSRV config warning only)
  • clud-review: APPROVE
  • attached stock Pico: rebuilt editable package and reproduced Windows error 1392; live fbuild output included the new safety diagnostic and then attempted managed picotool

Part of #1049.

Summary by CodeRabbit

  • Bug Fixes
    • Improved UF2 deployment error messages on Windows when the BOOTSEL volume reports error 1392.
    • Added actionable guidance to retry in BOOTSEL mode or use the managed fallback tool.
    • Preserved general fallback guidance for other UF2 copy failures.

@zackees
zackees merged commit 29adb7a into main Jul 15, 2026
79 of 93 checks passed
@zackees
zackees deleted the fix/rp2040-windows-volume-diagnostic branch July 15, 2026 05:05
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f757c9d4-0865-481a-b07e-475318c10afb

📥 Commits

Reviewing files that changed from the base of the PR and between 9b4e656 and 199da7d.

📒 Files selected for processing (1)
  • crates/fbuild-deploy/src/rp2040.rs

📝 Walkthrough

Walkthrough

UF2 copy failures now use a dedicated formatter. Windows error 1392 receives guidance about the synthetic BOOTSEL FAT volume, avoiding repair or formatting, and using BOOTSEL or the managed picotool fallback. A unit test verifies the resulting message.

Changes

UF2 copy error handling

Layer / File(s) Summary
Format and test UF2 copy failures
crates/fbuild-deploy/src/rp2040.rs
UF2 copy errors are formatted through a helper with Windows error 1392 guidance, and a unit test verifies the synthetic volume and managed picotool fallback messaging.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • FastLED/fbuild#1041: Introduces the RP2040 UF2/BOOTSEL copy-based deployer that this error-handling change updates.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/rp2040-windows-volume-diagnostic

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant