Skip to content

fix(ci): update CH32V path filters after crate split#1110

Merged
zackees merged 1 commit into
mainfrom
fix/ch32v-ci-path-filters
Jul 21, 2026
Merged

fix(ci): update CH32V path filters after crate split#1110
zackees merged 1 commit into
mainfrom
fix/ch32v-ci-path-filters

Conversation

@zackees

@zackees zackees commented Jul 21, 2026

Copy link
Copy Markdown
Member

Closes #1107

Summary:

  • update common and family path filters to the split crate layout
  • add renderer validation for dead source-of-truth paths
  • regenerate all per-board workflows

Validation:

  • uv run --no-project python ci/render_workflows.py
  • uv run --no-project python ci/render_workflows.py --check
  • deliberate bogus-path probe fails as expected

Summary by CodeRabbit

  • CI Improvements
    • Updated build triggers across supported boards to better match relevant platform and shared build changes.
    • Broadened coverage for shared toolchain, library, package, and build-system updates.
    • Reduced unnecessary workflow runs caused by outdated or overly granular path filters.
    • Added validation to detect stale or invalid CI source paths before workflows are generated.

@zackees
zackees merged commit 41deed2 into main Jul 21, 2026
87 of 93 checks passed
@zackees
zackees deleted the fix/ch32v-ci-path-filters branch July 21, 2026 23:25
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3009f043-651f-46e9-b544-ddf02a2b7079

📥 Commits

Reviewing files that changed from the base of the PR and between eb2a91a and 0fc6750.

📒 Files selected for processing (82)
  • .github/workflows/build-apollo3_red.yml
  • .github/workflows/build-apollo3_thing_explorable.yml
  • .github/workflows/build-atmega8.yml
  • .github/workflows/build-atmega8a.yml
  • .github/workflows/build-attiny1604.yml
  • .github/workflows/build-attiny1616.yml
  • .github/workflows/build-attiny4313.yml
  • .github/workflows/build-attiny85.yml
  • .github/workflows/build-attiny88.yml
  • .github/workflows/build-blackpill.yml
  • .github/workflows/build-bluepill.yml
  • .github/workflows/build-ch32l103.yml
  • .github/workflows/build-ch32v003.yml
  • .github/workflows/build-ch32v006.yml
  • .github/workflows/build-ch32v103.yml
  • .github/workflows/build-ch32v203.yml
  • .github/workflows/build-ch32v208.yml
  • .github/workflows/build-ch32v303.yml
  • .github/workflows/build-ch32v307.yml
  • .github/workflows/build-ch32x035.yml
  • .github/workflows/build-due.yml
  • .github/workflows/build-esp32c2.yml
  • .github/workflows/build-esp32c3.yml
  • .github/workflows/build-esp32c5.yml
  • .github/workflows/build-esp32c6.yml
  • .github/workflows/build-esp32dev.yml
  • .github/workflows/build-esp32h2.yml
  • .github/workflows/build-esp32p4.yml
  • .github/workflows/build-esp32s2.yml
  • .github/workflows/build-esp32s3.yml
  • .github/workflows/build-esp8266.yml
  • .github/workflows/build-giga-r1.yml
  • .github/workflows/build-leonardo.yml
  • .github/workflows/build-lpc804.yml
  • .github/workflows/build-lpc845.yml
  • .github/workflows/build-lpc845brk.yml
  • .github/workflows/build-lpcxpresso804.yml
  • .github/workflows/build-lpcxpresso845max.yml
  • .github/workflows/build-matrix_portal_m4.yml
  • .github/workflows/build-mgm240.yml
  • .github/workflows/build-nano-every.yml
  • .github/workflows/build-nano_every.yml
  • .github/workflows/build-nice_nano_nrf52840.yml
  • .github/workflows/build-nrf52840-sense.yml
  • .github/workflows/build-nrf52840_dk.yml
  • .github/workflows/build-nrfmicro_nrf52840.yml
  • .github/workflows/build-nucleo-f429zi.yml
  • .github/workflows/build-nucleo-f439zi.yml
  • .github/workflows/build-nucleo_f429zi.yml
  • .github/workflows/build-nucleo_f439zi.yml
  • .github/workflows/build-qtpy_m0.yml
  • .github/workflows/build-rp2040.yml
  • .github/workflows/build-rp2350.yml
  • .github/workflows/build-rpipico.yml
  • .github/workflows/build-rpipico2.yml
  • .github/workflows/build-sam3x8e_due.yml
  • .github/workflows/build-samd21.yml
  • .github/workflows/build-samd21_zero.yml
  • .github/workflows/build-samd51j.yml
  • .github/workflows/build-samd51p.yml
  • .github/workflows/build-stm32f103c8.yml
  • .github/workflows/build-stm32f103cb.yml
  • .github/workflows/build-stm32f103tb.yml
  • .github/workflows/build-stm32f411ce.yml
  • .github/workflows/build-stm32h747xi.yml
  • .github/workflows/build-supermini_nrf52840.yml
  • .github/workflows/build-teensy30.yml
  • .github/workflows/build-teensy31.yml
  • .github/workflows/build-teensy32.yml
  • .github/workflows/build-teensy35.yml
  • .github/workflows/build-teensy36.yml
  • .github/workflows/build-teensy40.yml
  • .github/workflows/build-teensy41.yml
  • .github/workflows/build-teensylc.yml
  • .github/workflows/build-thingplusmatter.yml
  • .github/workflows/build-tinystm.yml
  • .github/workflows/build-uno-r4-wifi.yml
  • .github/workflows/build-uno.yml
  • .github/workflows/build-uno_r4_wifi.yml
  • ci/board_families.json
  • ci/ci_common_paths.txt
  • ci/render_workflows.py

📝 Walkthrough

Walkthrough

The PR updates generated board workflow path filters to match split build crates, revises CI path source-of-truth files, and adds validation that configured source patterns exist before workflows are rendered.

Changes

CI path filter migration

Layer / File(s) Summary
Per-board trigger paths
.github/workflows/build-*.yml
Push and pull-request filters replace legacy crates/fbuild-build/src/** entries with family-specific build paths and shared build-system crate globs.
CI path sources
ci/board_families.json, ci/ci_common_paths.txt
Family and common path definitions now reference the split crate structure and shared build components.
Source path validation
ci/render_workflows.py
Rendering validates configured glob patterns against repository files and exits with an error when patterns are stale.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related issues

  • Issue 1107 — Updates the same stale CH32V and split-crate workflow path filters.
  • Issue 1102 — Covers the broader CI path-filter migration and dead-path validation.

Possibly related PRs

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ch32v-ci-path-filters

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

ci: build-ch32*.yml path filters point at pre-split crates/fbuild-build/src/ch32v/** — CH32V build-code PRs trigger no platform builds

1 participant