Skip to content

fix(ch32v): honor board ISA and ABI settings#1113

Merged
zackees merged 1 commit into
mainfrom
fix/ch32v-board-isa
Jul 21, 2026
Merged

fix(ch32v): honor board ISA and ABI settings#1113
zackees merged 1 commit into
mainfrom
fix/ch32v-board-isa

Conversation

@zackees

@zackees zackees commented Jul 21, 2026

Copy link
Copy Markdown
Member

Closes #1106

Summary:

  • load board build.march and build.mabi into BoardConfig
  • normalize and apply CH32V ISA/ABI flags to compile and link commands
  • add focused normalization, propagation, and compiler tests

Validation:

  • soldr rustfmt --check on all changed Rust files
  • soldr cargo check -p fbuild-build-mcu -p fbuild-config --lib (shared Windows toolchain did not return within the local validation window)

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 35 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: fffb5ef4-b745-4496-8440-0c16fc9c3c02

📥 Commits

Reviewing files that changed from the base of the PR and between c46bd3d and c54edd3.

📒 Files selected for processing (6)
  • crates/fbuild-build-mcu/src/ch32v/ch32v_compiler.rs
  • crates/fbuild-build-mcu/src/ch32v/mcu_config.rs
  • crates/fbuild-build-mcu/src/ch32v/orchestrator.rs
  • crates/fbuild-config/src/board/db.rs
  • crates/fbuild-config/src/board/loaders.rs
  • crates/fbuild-config/src/board/types.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ch32v-board-isa

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

ch32v: board JSON march/mabi are dead — every series compiles as RV32EC/ilp32e, IMAC parts get software multiply

1 participant