Skip to content

fix(toolchain): resolve RISC-V C++ multilib from GCC#1132

Merged
zackees merged 1 commit into
mainfrom
fix/1118-riscv-multilib
Jul 22, 2026
Merged

fix(toolchain): resolve RISC-V C++ multilib from GCC#1132
zackees merged 1 commit into
mainfrom
fix/1118-riscv-multilib

Conversation

@zackees

@zackees zackees commented Jul 22, 2026

Copy link
Copy Markdown
Member

Closes #1118\n\nUse GCC's -print-multi-directory result when constructing the xPack C++ multilib include path. This handles the default . multilib used by rv32imac/ilp32 and preserves extension-bearing directories such as
v32imafc_zicsr/ilp32f.\n\nValidation: soldr cargo test -p fbuild-toolchain toolchain::riscv --lib (9 passed); soldr rustfmt --check crates/fbuild-toolchain/src/toolchain/riscv.rs.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 9 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 813f429d-330b-4074-9d95-89d9c77eaf87

📥 Commits

Reviewing files that changed from the base of the PR and between 204c7a6 and c1194df.

📒 Files selected for processing (1)
  • crates/fbuild-toolchain/src/toolchain/riscv.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/1118-riscv-multilib

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit 8973b01 into main Jul 22, 2026
88 of 93 checks passed
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

fix(toolchain): riscv g++ -isystem set misses the default multilib dir - rv32imac CH32V C++ builds fail on Windows

1 participant