Skip to content

chore(ch32v): tighten toolchain and build hygiene - #1143

Merged
zackees merged 1 commit into
mainfrom
chore/issue-1129-ch32v-hygiene
Jul 22, 2026
Merged

chore(ch32v): tighten toolchain and build hygiene#1143
zackees merged 1 commit into
mainfrom
chore/issue-1129-ch32v-hygiene

Conversation

@zackees

@zackees zackees commented Jul 22, 2026

Copy link
Copy Markdown
Member

Closes #1129

Pins SHA-256 checksums for all four xPack RISC-V toolchain assets using the release's published .sha sidecars; rejects malformed non-CH32V MCU names instead of silently selecting the V003 fallback; documents V30x codegen divergence and known pin-map reuse; and adds CH32V/WCH-LinkE USB CDC control-line guidance.

The deploy-message items in the issue refer to a minichlink fallback path that is not present in the current daemon implementation, so no unrelated fallback code was invented.

Validation:

  • soldr cargo fmt --all
  • soldr cargo test -p fbuild-toolchain toolchain::riscv --lib
  • soldr cargo test -p fbuild-build-mcu ch32v::orchestrator --lib
  • soldr cargo check -p fbuild-toolchain -p fbuild-build-mcu
  • git diff --check

@zackees
zackees merged commit c628ca5 into main Jul 22, 2026
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 26 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0a82d861-1315-4843-a7e6-1afade4694f5

📥 Commits

Reviewing files that changed from the base of the PR and between 44c0be3 and 203b318.

📒 Files selected for processing (4)
  • crates/fbuild-build-mcu/src/ch32v/README.md
  • crates/fbuild-build-mcu/src/ch32v/orchestrator.rs
  • crates/fbuild-toolchain/src/toolchain/riscv.rs
  • docs/usb-cdc-control-line-matrix.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/issue-1129-ch32v-hygiene

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

chore(ch32v): LOW batch - toolchain checksums, silent series fallback, dead JSON fields, variant pin-map docs, DTR/RTS matrix rows, deploy-message nits

1 participant