Skip to content

feat(windows): add scoped USB recovery helper foundation#1151

Merged
zackees merged 1 commit into
mainfrom
fix/1148-usb-recovery
Jul 23, 2026
Merged

feat(windows): add scoped USB recovery helper foundation#1151
zackees merged 1 commit into
mainfrom
fix/1148-usb-recovery

Conversation

@zackees

@zackees zackees commented Jul 23, 2026

Copy link
Copy Markdown
Member

Fixes #1148\n\nImplements the scoped recovery foundation without elevating or restarting the daemon:\n- typed core recovery request/result and explicit deploy policy;\n- hidden current-executable helper routed before daemon setup;\n- constrained Config Manager identity revalidation and only parent re-enumeration/exact-child restart;\n- UAC launcher with nonce-bound create-new rendezvous, cancellation cleanup, and reparse-point rejection;\n- deterministic policy, identity, and operation-allowlist tests.\n\nRP2040 is intentionally not yet wired to emit or consume the typed request; #1147 remains the sole integration/hardware-validation child.\n\nValidation:\n- soldr cargo test -p fbuild-serial usb_recovery\n- soldr cargo test -p fbuild-cli usb_recovery\n- soldr cargo test -p fbuild-cli deploy_admin_and_no_admin_conflict\n- soldr cargo test -p fbuild-cli hidden_usb_recovery_helper_arguments_parse\n- soldr cargo check -p fbuild-cli -p fbuild-daemon\n- soldr cargo clippy -p fbuild-core -p fbuild-serial -p fbuild-cli -p fbuild-daemon --all-targets -- -D warnings

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 1 minute

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7a6e10b2-159f-49cd-adbb-857f0f19b348

📥 Commits

Reviewing files that changed from the base of the PR and between 66f73ac and 5bce453.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (15)
  • crates/fbuild-cli/Cargo.toml
  • crates/fbuild-cli/src/cli/args.rs
  • crates/fbuild-cli/src/cli/deploy.rs
  • crates/fbuild-cli/src/cli/dispatch.rs
  • crates/fbuild-cli/src/cli/mod.rs
  • crates/fbuild-cli/src/cli/tests.rs
  • crates/fbuild-cli/src/cli/usb_recovery.rs
  • crates/fbuild-cli/src/daemon_client/types.rs
  • crates/fbuild-cli/src/mcp/tools.rs
  • crates/fbuild-core/src/usb/mod.rs
  • crates/fbuild-core/src/usb/recovery.rs
  • crates/fbuild-daemon/src/models.rs
  • crates/fbuild-serial/Cargo.toml
  • crates/fbuild-serial/src/lib.rs
  • crates/fbuild-serial/src/usb_recovery.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/1148-usb-recovery

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

feat(windows): add scoped elevated USB PnP recovery helper

1 participant