Preserve fbuild daemon environment overrides#1170
Conversation
|
Warning Review limit reached
Next review available in: 37 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
running-process 4.6.1 changed user_baseline_environment() on Unix from a snapshot of the current process environment to a scrubbed login baseline (USER/LOGNAME/HOME/SHELL/default PATH + locale/TZ/TMPDIR only). The daemon spawn sites do env_clear().envs(baseline), so SOLDR_CACHE_DIR stopped reaching the daemon: it bound its socket under the default ~/.soldr root while wrappers polled $SOLDR_CACHE_DIR/cache/soldr-daemon/sock, burned the full 30s spawn-retry budget on NotRunning, wrote the daemon-unavailable marker, and every compile fell back to direct uncached rustc (soldr#1657 degradation firing on all Linux CI lanes; 400 fallback lines in the cancelled 0.8.23 release run). Overlay the whole SOLDR_* namespace (case-insensitive, matching the FBUILD_* passthrough in FastLED/fbuild#1170) on top of the baseline at all three spawn sites: both Unix Command spawns and the Windows CreateProcessW environment block, which has always been scrubbed via CreateEnvironmentBlock and silently relied on the default root. Verified in the Linux docker runner: before, a hello-world build stalled 30s and built uncached with the daemon socket in ~/.soldr-dev; after, the daemon binds under $SOLDR_CACHE_DIR and the build completes in ~1s with no fallback lines. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Summary
This addresses the review finding on #1169, including FBUILD_DAEMON_PORT, after that PR auto-merged before the follow-up commit landed.
Validation