chore(release): bump 2.5.3 -> 2.5.4 — running-process 4.6.1 (daemon env USERNAME fix)#1171
Merged
Conversation
…nv USERNAME fix) running-process ≤4.6.0 built detached daemons' baseline env via CreateEnvironmentBlock with a TOKEN_QUERY-only token, silently omitting the per-user dynamic variables (USERNAME, USERDOMAIN). 4.6.1 opens the token with the documented access mask and, on Unix, reconstructs a real login environment via getpwuid_r instead of inheriting the parent env. See zackees/running-process#655. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe project version is bumped from 2.5.3 to 2.5.4 in Cargo and Python metadata, and the ChangesRelease metadata
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CreateEnvironmentBlockwas called with a TOKEN_QUERY-only token, silently droppingUSERNAME/USERDOMAINfrom detached daemons' baseline environment (this is what split soldr's daemon pipe name from its clients). UnixUserBaselinenow reconstructs a real login env viagetpwuid_r. See fix(env): restore USERNAME in Windows baseline env; real login env on Unix (4.6.1) zackees/running-process#655.Validation
cargo check -p fbuild-daemon(the running-process backend consumer) compiles clean against 4.6.1.🤖 Generated with Claude Code
Summary by CodeRabbit
running-processdependency to version 4.6.1.