Skip to content

fix: align embedded zccache with soldr#1176

Merged
zackees merged 4 commits into
mainfrom
fix/zccache-embedded-version
Jul 24, 2026
Merged

fix: align embedded zccache with soldr#1176
zackees merged 4 commits into
mainfrom
fix/zccache-embedded-version

Conversation

@zackees

@zackees zackees commented Jul 24, 2026

Copy link
Copy Markdown
Member

Summary

  • align both fbuild embedded zccache dependencies with soldr's _vender/zccache revision
  • move from zccache 1.12.14 (4b13676) to 1.12.17 (a16f10e)
  • refresh the lockfile so all zccache subcrates use the same revision

This prevents fbuild and soldr from loading different embedded broker implementations on the same host.

Validation

  • soldr cargo metadata --locked --no-deps --format-version 1
  • git diff --check
  • attempted soldr cargo test -p fbuild-build --test zccache_embedded_smoke -- --nocapture and soldr cargo check -p fbuild-build-engine; both were stopped by the local five-minute cold-build cap without compiler or test diagnostics. CI remains the full build/test gate.

Coordinated with zackees/zccache#1213.

Summary by CodeRabbit

  • Chores
    • Updated the pinned build-cache dependency revision to a newer version.
    • Applied the same dependency update consistently across build components.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 15 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 936d96bd-a0a0-49b4-b4b1-1b82d00aba80

📥 Commits

Reviewing files that changed from the base of the PR and between 8810d27 and 13ab52d.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (7)
  • crates/fbuild-build-arm/Cargo.toml
  • crates/fbuild-build-esp/Cargo.toml
  • crates/fbuild-build-mcu/Cargo.toml
  • crates/fbuild-cli/src/cli/clean.rs
  • crates/fbuild-core/src/process_identity.rs
  • crates/fbuild-paths/src/daemon_ownership.rs
  • crates/fbuild-serial/src/ports.rs
📝 Walkthrough

Walkthrough

The pull request updates the pinned zccache Git revision in both build-related Cargo manifests while retaining the existing repository URL.

Changes

zccache dependency pin update

Layer / File(s) Summary
Synchronize zccache revisions
crates/fbuild-build/Cargo.toml, crates/fbuild-build-engine/Cargo.toml
Both manifests now pin zccache to revision a16f10e2c3813f0582e0e51eb3b9932c727435f1; the related revision comment is updated.
Estimated code review effort: 1 (Trivial) ~2 minutes

Possibly related PRs

  • FastLED/fbuild#981: Updates the same zccache Git dependency pin in crates/fbuild-build/Cargo.toml.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: aligning embedded zccache with soldr.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/zccache-embedded-version

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit 2e8a796 into main Jul 24, 2026
82 of 93 checks passed
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant