feat(packages): hoist platform_packages override into PackageBase (foundation + LPC8xx, closes #681)

[zackees]

Summary

Foundation + LPC8xx wiring for #681 (audit follow-up to #664, originally reported in #663). Hoists platform_packages override semantics into the PackageBase abstract class so the same fix automatically propagates to every framework orchestrator instead of being hand-wired 16 times.

• fbuild-config: new PackageOverride { url, version, checksum } type and parse_platform_packages_entry / parse_platform_packages_value parsers. Accepts name@<URL>#<sha> and name@<owner/repo>#<sha>; correctly returns None for registry version pins (name @ 1.2.3).
• fbuild-packages: PackageBase::with_override(ovr) replaces url + cache_key (← override URL, the load-bearing field) + version + checksum; preserves name + cache_subdir. One tracing::info! per override so the override is visible in build scrollback across every framework package without each orchestrator having to remember to log it.
• fbuild-build: shared package_override::resolve_override(env_config, package_name) helper scans the multi-line platform_packages value.
• ArduinoCoreLpc8xx::with_override delegates to the base. nxplpc orchestrator consults resolve_override — the originally-reported LPC8xx bisection workflow (nxplpc: framework-arduino-lpc8xx pin is hardcoded — platform_packages override in platformio.ini is silently ignored (blocks FastLED#3325 bisection) #663, [#3300 bisect] Find the commit that broke LPC845-BRK JSON-RPC echo — bisect Arduino-core LPC8xx FastLED#3325) is unblocked.

Why the abstract-class approach

#664's audit confirmed the bug is universal (16/16 framework packages). Doing this as 16 parallel patches gives 16 chances to miss the override-visibility log, get the cache-key derivation subtly different, or forget multi-line tolerance. Hoisting once means future framework packages inherit override support by construction — see crates/CLAUDE.md monocrate policy and the code-review skill's "code that belongs in core instead of platform crates" rule.

Test plan

• package_override_tests::override_changes_install_path — the test the issue calls out by name. Asserts that the default pin, an override at commit A, and an override at commit B (same upstream repo, different SHAs) all hash to distinct cache directories. Without this, a bisection step that swaps the URL would silently reuse the previous commit's vendored sources.
• package_override_tests::override_replaces_url_cache_key_version_and_checksum — pins the cache_key swap directly so a future refactor can't accidentally preserve the default cache_key while updating only url.
• platform_packages::tests — 7 parser cases (URL+sha, owner/repo+sha, version-only-returns-None, multi-line first-match, trailing comma/semicolon tolerance, non-matching name, blank lines).
• package_override::tests — 5 helper cases (env-with-match, missing-key, no-matching-name, multi-line first-match, version-pin-returns-None).
• soldr cargo clippy -p fbuild-config -p fbuild-packages -p fbuild-build --all-targets -- -D warnings — clean.
• soldr cargo test -p fbuild-config -p fbuild-packages -p fbuild-build --lib — 728 + 176 + 453 = 1357 tests, 0 failed.

Drive-by

Stabilized managed_zccache::tests::install_lock_blocks_second_caller_until_released. Its 40ms wall-clock deadline was racing std::thread::spawn scheduling latency under parallel-test contention — if the waiter wasn't scheduled before drop(first), it would acquire instantly and the test would fail with waited ≈ 0ms. New shape uses JoinHandle::is_finished() to prove contention directly, with a soft non-zero elapsed sanity check.

Follow-up (not in this PR)

The remaining 15 framework orchestrators (apollo3, arduino_api, avr, attiny, ch32v, esp32, esp8266, nrf52, renesas, rp2040, sam, samd, silabs, stm32, teensy, arduino_mbed) follow the same uniform 3-line delta pattern against the shared resolve_override helper and a per-package with_override constructor. That's a mechanical sweep PR with the abstraction now in place.

Closes #681
Refs #663, #664, FastLED/FastLED#3325

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

@zackees, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 25 minutes and 2 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 67d3528b-ba99-4667-8450-ce558bd40fb7

📥 Commits

Reviewing files that changed from the base of the PR and between cd998e0 and 7408bda.

📒 Files selected for processing (10)

• crates/fbuild-build/src/lib.rs
• crates/fbuild-build/src/managed_zccache.rs
• crates/fbuild-build/src/nxplpc/mod.rs
• crates/fbuild-build/src/nxplpc/orchestrator.rs
• crates/fbuild-build/src/nxplpc/platform_packages.rs
• crates/fbuild-build/src/package_override.rs
• crates/fbuild-config/src/lib.rs
• crates/fbuild-config/src/platform_packages.rs
• crates/fbuild-packages/src/lib.rs
• crates/fbuild-packages/src/library/arduino_core_lpc8xx.rs

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/681-package-override

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}