Skip to content

chore: remove stale standalone-zccache references (#855)#883

Merged
zackees merged 1 commit into
mainfrom
fix/855-stale-zccache-refs
Jun 30, 2026
Merged

chore: remove stale standalone-zccache references (#855)#883
zackees merged 1 commit into
mainfrom
fix/855-stale-zccache-refs

Conversation

@zackees

@zackees zackees commented Jun 30, 2026

Copy link
Copy Markdown
Member

Four mechanical sites cleaned up per #855:

  1. ci/docker-mac-cross/Dockerfile — for-loop dropped zccache zccache-daemon zccache-fp. soldr 1.12.11+ doesn't ship them; the loop would silently no-op past SOLDR_VERSION=0.7.59.
  2. .github/workflows/template_build.yml — removed Reset zccache daemon after cache warm step. No standalone zccache-daemon process exists post-embedded-zccache; the daemon lifecycle is owned by soldr.
  3. setup.py docstring — updated to describe the embedded-zccache architecture (RUSTC_WRAPPER = soldr / zccache-soldr shim, which talks to soldr-daemon's embedded zccache).
  4. crates/fbuild-build/src/compile_database/tests/cache_wrapper.rs — added a doc comment to test_strip_zccache_wrap_mode marking it as a backward-compat parse assertion for legacy command-line shapes (test still passes; the shape just shouldn't show up in new code paths).

References

Verification

Closes #855

🤖 Generated with Claude Code

soldr 1.12.11+ embeds zccache into soldr-daemon (soldr#977 / #980 L1)
and the new dedicated `zccache-soldr` shim (soldr#1081) is the
RUSTC_WRAPPER. No standalone `zccache.exe` / `zccache-daemon` /
`zccache-fp` binaries ship anymore. Four sites in fbuild still
referenced the legacy architecture; this PR brings them in line.

1. `ci/docker-mac-cross/Dockerfile` — for-loop dropped
   `zccache zccache-daemon zccache-fp` (would silently no-op past
   `SOLDR_VERSION=0.7.59`).
2. `.github/workflows/template_build.yml` — removed the
   "Reset zccache daemon after cache warm" step (no standalone
   `zccache-daemon` process to kill — daemon lifecycle is owned
   by soldr).
3. `setup.py` docstring — updated to describe the embedded-zccache
   architecture (RUSTC_WRAPPER points at soldr / `zccache-soldr`,
   which talks to soldr-daemon's embedded zccache).
4. `crates/fbuild-build/src/compile_database/tests/cache_wrapper.rs`
   — added a doc comment above `test_strip_zccache_wrap_mode`
   marking it as a backward-compat parse assertion for the legacy
   `zccache.exe wrap` command-line shape, kept so historical
   `compile_commands.json` fragments still strip cleanly.

Closes #855
@zackees
zackees merged commit e8fcffb into main Jun 30, 2026
78 of 93 checks passed
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 38 seconds

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 524047d4-a3ec-42d8-bd02-0dfe01c5bac1

📥 Commits

Reviewing files that changed from the base of the PR and between 9e52375 and ce5cdf9.

📒 Files selected for processing (4)
  • .github/workflows/template_build.yml
  • ci/docker-mac-cross/Dockerfile
  • crates/fbuild-build/src/compile_database/tests/cache_wrapper.rs
  • setup.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/855-stale-zccache-refs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees deleted the fix/855-stale-zccache-refs branch June 30, 2026 17:56
zackees added a commit that referenced this pull request Jun 30, 2026
Rolls up the fixes shipped since 2.3.14:

- #855 (#883) — drop stale standalone-zccache CI/Docker/docs references
  after the soldr embedded-zccache transition (soldr#977/#980/#1081)
- #865 (#884) — write daemon status via sync write_atomic; unblocks
  fbuild-daemon unit tests on macOS/Windows by eliminating the
  block_in_place panic in current-thread tokio runtimes
- #875 (#885) — pin TMP/TEMP for compiler subprocess on Windows; ESP32
  compile no longer fails with 'Cannot create temporary file in
  C:\Windows\' on the very first TU
- #720 (#886) — record anti-removal policy for dump_usb_ids example
- #829 (#887) — stage fbuild._native cdylib during source/editable
  install so 'from fbuild import ...' works after 'uv pip install -e .'

Plus all prior #664 platform_packages audit work, the #826 testing
followups, and the build cancellation fix from earlier in the cycle.
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

Stale standalone-zccache references in CI / Docker / docs / tests (post-embedded-zccache transition)

1 participant