fix(packages): bump ArduinoCore-LPC8xx past the phantom-DMA revert (#916 follow-up) - #918
Conversation
follow-up) Bumps `ACLPC_COMMIT` past `FastLED/framework-arduino-lpc8xx#35` (the phantom LPC804 `DMA_Type` addition) to the revert HEAD `8836a9bb08c77273758776aa3e8a233e97ff97cf`, which is the tip of `main` after `FastLED/framework-arduino-lpc8xx#36` (revert) merged. Also updates the `ACLPC_CHECKSUM` to the SHA256 of the archive tarball GitHub currently serves for the new SHA: `e74c2226873ccf5676096b8e28c8a9acc4af39894c7fc651ea320628a69281ec` (verified via `curl … | sha256sum`). Cleans the stale doc comment that used to justify the bump to 1179200 with the phantom-peripheral rationale. ## Why the revert LPC804 silicon has no DMA peripheral. NXP's own `mcux-sdk` sources confirm: - `devices/LPC804/LPC804.h` — zero `DMA_Type` typedef, zero `DMA0_BASE` - `devices/LPC804/LPC804_features.h` — no `FSL_FEATURE_SOC_DMA_COUNT` - `devices/LPC804/drivers/` — no `fsl_inputmux_connections.h` - UM11065 — 3 DMA hits total, all copy-paste leftovers, no DMA chapter 0x50008000 is a reserved AHB slot on LPC804. Diagnosed by @phatpaul in FastLED/FastLED#3499 comment 4855252061. FastLED-side revert cascade: FastLED/FastLED#3513. FastLED#3499 closed as INVALID. Preventive guardrail: FastLED/FastLED#3506 / #3507 (`agents/docs/peripheral-existence.md`) — agents must now grep vendor CMSIS + features flag + drivers/ before writing any driver code that names a `<Peripheral>_Type` typedef. All four "absent" → halt. Refs: FastLED/framework-arduino-lpc8xx#36 (upstream revert), FastLED/FastLED#3513, FastLED/FastLED#3499, FastLED/FastLED#3517 (meta issue Phase D). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 52 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bumps
ACLPC_COMMITpast FastLED/framework-arduino-lpc8xx#35 (the phantom LPC804DMA_Typeaddition) to the revert HEAD8836a9bb08, which is the tip ofmainafter FastLED/framework-arduino-lpc8xx#36 merged.Why the revert
LPC804 silicon has no DMA peripheral. NXP's own mcux-sdk confirms:
devices/LPC804/LPC804.h— zeroDMA_Typetypedef, zeroDMA0_BASEdevices/LPC804/LPC804_features.h— noFSL_FEATURE_SOC_DMA_COUNTdevices/LPC804/drivers/— nofsl_inputmux_connections.h0x50008000 is a reserved AHB slot on LPC804.
Diagnosed by @phatpaul in FastLED/FastLED#3499 comment 4855252061. FastLED-side revert cascade: FastLED#3513 (merged). FastLED#3499 closed as INVALID.
Preventive guardrail: FastLED #3506 / #3507 (
agents/docs/peripheral-existence.md).What this PR does
ACLPC_COMMIT:1179200a30…→8836a9bb08…ACLPC_VERSION:0.2.1+g1179200→0.2.2+g8836a9bACLPC_URL: updatedACLPC_CHECKSUM:6b87823e8db6…→e74c2226873c…(verifiedcurl … | sha256sum)Refs: FastLED/framework-arduino-lpc8xx#36, FastLED/FastLED#3513, FastLED/FastLED#3499, FastLED/FastLED#3517 (meta issue Phase D).