Skip to content

fix(packages): bump ArduinoCore-LPC8xx past the phantom-DMA revert (#916 follow-up) - #918

Merged
zackees merged 1 commit into
mainfrom
bump-aclpc-post-phantom-revert
Jul 1, 2026
Merged

fix(packages): bump ArduinoCore-LPC8xx past the phantom-DMA revert (#916 follow-up)#918
zackees merged 1 commit into
mainfrom
bump-aclpc-post-phantom-revert

Conversation

@zackees

@zackees zackees commented Jul 1, 2026

Copy link
Copy Markdown
Member

Bumps ACLPC_COMMIT past FastLED/framework-arduino-lpc8xx#35 (the phantom LPC804 DMA_Type addition) to the revert HEAD 8836a9bb08, which is the tip of main after FastLED/framework-arduino-lpc8xx#36 merged.

Why the revert

LPC804 silicon has no DMA peripheral. NXP's own mcux-sdk confirms:

  • devices/LPC804/LPC804.h — zero DMA_Type typedef, zero DMA0_BASE
  • devices/LPC804/LPC804_features.h — no FSL_FEATURE_SOC_DMA_COUNT
  • devices/LPC804/drivers/ — no fsl_inputmux_connections.h
  • UM11065 — 3 DMA hits total, all copy-paste leftovers, no DMA chapter

0x50008000 is a reserved AHB slot on LPC804.

Diagnosed by @phatpaul in FastLED/FastLED#3499 comment 4855252061. FastLED-side revert cascade: FastLED#3513 (merged). FastLED#3499 closed as INVALID.

Preventive guardrail: FastLED #3506 / #3507 (agents/docs/peripheral-existence.md).

What this PR does

  • ACLPC_COMMIT: 1179200a30…8836a9bb08…
  • ACLPC_VERSION: 0.2.1+g11792000.2.2+g8836a9b
  • ACLPC_URL: updated
  • ACLPC_CHECKSUM: 6b87823e8db6…e74c2226873c… (verified curl … | sha256sum)
  • Cleans the stale doc comment that justified the bump to 1179200 with the phantom-peripheral rationale

Refs: FastLED/framework-arduino-lpc8xx#36, FastLED/FastLED#3513, FastLED/FastLED#3499, FastLED/FastLED#3517 (meta issue Phase D).

 follow-up)

Bumps `ACLPC_COMMIT` past `FastLED/framework-arduino-lpc8xx#35` (the
phantom LPC804 `DMA_Type` addition) to the revert HEAD
`8836a9bb08c77273758776aa3e8a233e97ff97cf`, which is the tip of `main`
after `FastLED/framework-arduino-lpc8xx#36` (revert) merged.

Also updates the `ACLPC_CHECKSUM` to the SHA256 of the archive tarball
GitHub currently serves for the new SHA:
`e74c2226873ccf5676096b8e28c8a9acc4af39894c7fc651ea320628a69281ec`
(verified via `curl … | sha256sum`).

Cleans the stale doc comment that used to justify the bump to 1179200
with the phantom-peripheral rationale.

## Why the revert

LPC804 silicon has no DMA peripheral. NXP's own `mcux-sdk` sources
confirm:
- `devices/LPC804/LPC804.h` — zero `DMA_Type` typedef, zero `DMA0_BASE`
- `devices/LPC804/LPC804_features.h` — no `FSL_FEATURE_SOC_DMA_COUNT`
- `devices/LPC804/drivers/` — no `fsl_inputmux_connections.h`
- UM11065 — 3 DMA hits total, all copy-paste leftovers, no DMA chapter

0x50008000 is a reserved AHB slot on LPC804.

Diagnosed by @phatpaul in FastLED/FastLED#3499 comment 4855252061.
FastLED-side revert cascade: FastLED/FastLED#3513. FastLED#3499 closed
as INVALID.

Preventive guardrail: FastLED/FastLED#3506 / #3507
(`agents/docs/peripheral-existence.md`) — agents must now grep vendor
CMSIS + features flag + drivers/ before writing any driver code that
names a `<Peripheral>_Type` typedef. All four "absent" → halt.

Refs: FastLED/framework-arduino-lpc8xx#36 (upstream revert),
FastLED/FastLED#3513, FastLED/FastLED#3499, FastLED/FastLED#3517
(meta issue Phase D).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 15473a10-7946-40ca-9aec-73fb24e2c394

📥 Commits

Reviewing files that changed from the base of the PR and between b055b52 and d0fdd6a.

📒 Files selected for processing (1)
  • crates/fbuild-packages/src/library/arduino_core_lpc8xx.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bump-aclpc-post-phantom-revert

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit e4cca98 into main Jul 1, 2026
93 checks passed
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant