Skip to content

fix: finish cache-path and soldr follow-ups#999

Merged
zackees merged 2 commits into
mainfrom
fix/998-cache-soldr-followups
Jul 7, 2026
Merged

fix: finish cache-path and soldr follow-ups#999
zackees merged 2 commits into
mainfrom
fix/998-cache-soldr-followups

Conversation

@zackees

@zackees zackees commented Jul 7, 2026

Copy link
Copy Markdown
Member

Summary

  • Canonicalizes the compile CWD before stripping absolute compile args so macOS tempdir aliases/symlinks still produce project-relative cache keys.
  • Adds a Unix symlink regression test for the cache path helper.
  • Pins every workflow setup-soldr use to zackees/setup-soldr@v0.9.66 and explicitly requests soldr 0.8.0.
  • Bumps the repo Docker soldr release pins under ci/docker-* to 0.8.0.

Closes #998.

Validation

  • uv run --no-project python ci/render_workflows.py --check
  • git diff --check origin/main..HEAD
  • rg '0\\.7\\.98|0\\.7\\.92|v0\\.9\\.65|v0\\.9\\.64|setup-soldr@v0\\.9\\.65' .github ci (no matches)
  • SOLDR_COMPILE_REPLY_TIMEOUT_SECS=180 soldr cargo test -p fbuild-core path_arg_for_compile_cwd -- --nocapture
  • SOLDR_COMPILE_REPLY_TIMEOUT_SECS=180 soldr cargo test -p fbuild-build test_artifact_cache_signature_ignores_project_directory_name -- --nocapture
  • SOLDR_COMPILE_REPLY_TIMEOUT_SECS=180 soldr cargo test -p fbuild-build key_is_independent_of_project_directory_name -- --nocapture

Notes

#996 merged and closed #994/#995 before these follow-up commits reached main, so this PR carries only the missing follow-up work on top of the merged mainline.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 15 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: aee0392d-5ec0-4fb5-b205-c113a96139f9

📥 Commits

Reviewing files that changed from the base of the PR and between 74ae4d5 and ef5f526.

📒 Files selected for processing (16)
  • .github/workflows/acceptance-205.yml
  • .github/workflows/bench-205.yml
  • .github/workflows/check-macos.yml
  • .github/workflows/check-ubuntu.yml
  • .github/workflows/docs.yml
  • .github/workflows/dylint.yml
  • .github/workflows/fmt.yml
  • .github/workflows/msrv.yml
  • .github/workflows/release-auto.yml
  • .github/workflows/template_build.yml
  • .github/workflows/template_native_build.yml
  • .github/workflows/update-data.yml
  • ci/docker-mac-cross/Dockerfile
  • ci/docker-profile/Dockerfile
  • ci/publish.py
  • crates/fbuild-core/src/path.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/998-cache-soldr-followups

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit 371e394 into main Jul 7, 2026
100 of 104 checks passed
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

fix: land post-#996 cache-path and soldr pin follow-ups ci(dylint): decide and enforce Dylint as a required status check

1 participant