Skip to content

Update dependencies, fix plugin development - #126

Merged
ChugunovRoman merged 6 commits into
Figma-Linux:masterfrom
ricochet1k:master
Dec 29, 2020
Merged

Update dependencies, fix plugin development#126
ChugunovRoman merged 6 commits into
Figma-Linux:masterfrom
ricochet1k:master

Conversation

@ricochet1k

Copy link
Copy Markdown
Contributor
  • Updated dependencies where necessary. Many errors were fixed just from this. npm audit now shows 0 vulnerabilities. I tried to verify that everything still works.
  • Removed old unused dependencies.
  • Fixed ipc communication. Many functions were returning async functions, which were never called, instead of Promises. Tried to clean up logging to make it less repetitive and more helpful.
  • Added code to load local plugin sources from disk. Plugins now load essentially allowing to close Plan on supporting plugin creation through linux client #53 though there is still more to do. Auto-reloading probably doesn't work yet, but plugin authoring is the reason I got started on this project so I'll probably be sending more PRs soon.
  • List of local plugins now saves and restores.

@victorb

victorb commented Sep 27, 2020

Copy link
Copy Markdown

Been using this for couple of days and seems to work fine for plugin development. Very nice to finally have Figma running on linux for plugin dev! 👏 Linking existing plugin from disk, Reloading the plugin, inspecting with inspector, using js console and communication between ui/code seems to all be ok here, haven't found any issues that didn't already exist in Figma Desktop for windows. I have not tested the publishing part.

@victorb

victorb commented Sep 30, 2020

Copy link
Copy Markdown

@0000marcell did you make sure you run npm run build before npm run dev? Was added with these commits too.

Also, if you could show the output from running npm run dev, probably there is some error logged there that can help with troubleshooting.

@0000marcell

0000marcell commented Oct 1, 2020

Copy link
Copy Markdown
Contributor

I've figured out the problem when I log in with the browser and press the open Figma button, the browser opens a new instance and not the one running on dev mod, Now it's working, sorry for the false alarm, I'm gonna remove my comment

@0000marcell

Copy link
Copy Markdown
Contributor

@ricochet1k Thanks for the update, do you know is there's a way to make "open console" work ? I know i can run the app in dev mode and the console will open by default, but after the app is built and packed this becomes a problem

@ChugunovRoman

ChugunovRoman commented Dec 10, 2020

Copy link
Copy Markdown
Collaborator

@ricochet1k Can you resolve the conflicts?

@ChugunovRoman
ChugunovRoman merged commit 3f5a8c4 into Figma-Linux:master Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plan on supporting plugin creation through linux client

4 participants