Skip to content

feat: allow subgraph indexing errors - #176

Open
silent-cipher wants to merge 3 commits into
mainfrom
feat/allow-indexing-errors
Open

feat: allow subgraph indexing errors#176
silent-cipher wants to merge 3 commits into
mainfrom
feat/allow-indexing-errors

Conversation

@silent-cipher

Copy link
Copy Markdown
Collaborator

Copilot AI lite review requested due to automatic review settings September 7, 2026 06:51
@vercel

vercel Bot commented Sep 7, 2026

Copy link
Copy Markdown

Deployment failed for project pdp-explorer with the following error:

You don't have permission to create a Preview Deployment for this Vercel project: pdp-explorer.

View Documentation: https://vercel.com/docs/accounts/team-members-and-roles

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

There are blocking correctness/robustness issues in the new fetcher guard (TypeScript safety) and the banner logic now hides indexing errors unless the indexer is also delayed.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates the subgraph client to tolerate Graph Node indexing errors by (1) requesting partial data via subgraphError: allow on many queries and (2) treating indexing_error responses as non-fatal when the server still returns usable data. It also tweaks the UI banner logic around when indexing-error warnings are shown.

Changes:

  • Adds subgraphError: allow to many entity/root-field queries so Graph Node can return partial data even when indexing errors exist.
  • Updates the GraphQL fetcher to return data for 2xx responses that only contain indexing_error GraphQL errors.
  • Adjusts the IndexerLagBanner messaging/conditions around indexing errors vs. lag.
File summaries
File Description
subgraph-client/src/utility/queries.ts Adds subgraphError: allow to multiple queries to permit partial results under indexing errors.
subgraph-client/src/utility/fetcher.ts Swallows indexing_error-only GraphQL errors when the response includes usable data.
subgraph-client/src/components/shared/IndexerLagBanner.tsx Changes when the indexing-error banner is shown and expands the banner message.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread subgraph-client/src/utility/fetcher.ts
Comment thread subgraph-client/src/components/shared/IndexerLagBanner.tsx
@FilOzzy FilOzzy moved this from 📌 Triage to 🔎 Awaiting review in FOC Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 Awaiting review

Development

Successfully merging this pull request may close these issues.

3 participants