Skip to content

Check AI review gate before flipping WIP to Ready for review - #14

Merged
boolangery merged 1 commit into
mainfrom
fix/ai-review-gate-label-flicker
Sep 21, 2026
Merged

boolangery merged 1 commit into
mainfrom
fix/ai-review-gate-label-flicker

Conversation

@boolangery

@boolangery boolangery commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

Description

  • Check the AI review gate before flipping the label from Work in progress to Ready for review, not after.
  • When require_ai_review blocks reviewer assignment, the PR now stays on Work in progress instead of briefly flipping to Ready for review and back.
  • Manual re-apply of the Ready for review label is untouched.

@boolangery
boolangery added this pull request to stack #15 September 21, 2026 15:13
@boolangery
boolangery force-pushed the fix/ai-review-gate-label-flicker branch from 50f3193 to 5040224 Compare September 21, 2026 15:14
@boolangery
boolangery requested a review from Dal-Papa September 21, 2026 15:23
Base automatically changed from feature/optimize-RankUsersByReviewLoad to main September 21, 2026 15:51
Previously the label flipped WIP -> Ready for review -> WIP within the
same webhook when require_ai_review blocked reviewer assignment,
because the gate was only checked after the swap. Check it first and
skip the swap entirely when it fails.
@boolangery
boolangery force-pushed the fix/ai-review-gate-label-flicker branch from 5040224 to 0cdcf3d Compare September 21, 2026 15:51
@boolangery
boolangery merged commit 823704b into main Sep 21, 2026
3 checks passed
@Dal-Papa
Dal-Papa deleted the fix/ai-review-gate-label-flicker branch September 21, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants