Kotlin decryption. Test decryption errors after moving to use PGPainless for the message decryption

[DenBond7]

It would be nice to have such tests. I think it's very important to prevent security bugs (for example after upgrading PGPainless to a newer version). We should be sure that a received content is parsed to expected blocks and Android shows the expected UI.

[DenBond7]

I'm talking about things like this one

[DenBond7]

@tomholub It would be nice to create a list of the decryption errors that we would like to handle. I think it will be useful for all platforms

[tomholub]

Yes. All error scenarios that are interesting are represented in flowcrypt.compatibility account as email messages, so we can extract them from there (as you have done)

[tomholub]

tests/decrypt error label should have most of them. If you see any that are (expected) errors and not labeled that way, feel free to add the label, so that they are all in one place.

[DenBond7]

tests/decrypt error label should have most of them. If you see any that are (expected) errors and not labeled that way, feel free to add the label, so that they are all in one place.

For now, I see the following decryption errors

• 1. WRONG CHECKSUM - Message is either badly formatted or not compatible with FlowCrypt
• 2. NO_MDC - Security threat. The message is missing integrity checks (MDC)
• 3. BAD_MDC - Security threat. Opening this message is dangerous because it was modified in transit
• 4. KEY_MISMATCH - Message encrypted for public keys that don't match(An active account doesn't have a right private key). A message encrypted for another public key (only one public key used, the sender public key)
• 5. FORMAT - take any armored message, remove some lines from the middle, and then try to read it.

6. OTHER - when it throws some exception we don't recognize.

[tomholub]

5 and 6 are the same thing - should be returning KEY_MISMATCH error

Also there is FORMAT error - take any armored message, remove some lines from the middle, and then try to read it.

Encrypted message inside signed

This one doesn't really sound like an error.

[DenBond7]

Updated

[tomholub]

On browser extension I also have "other" when it throws some exception I don't recognize.

[tomholub]

I suppose you have something similar