use flowcrypt.com/shared-tenant-fes/ instead of flowcrypt.com/api for some requests

[tomholub]

part of https://github.com/FlowCrypt/flowcrypt-enterprise-on-prem/issues/4097

same as FlowCrypt/flowcrypt-browser#4890 except on Android

please also respect the naming of potentialCustomUrlFes vs sharedTenantFes, both of which are instances of the same class called ExternalService / ExternalServiceXxx (instead of previously EnterpriseServer)

[DenBond7]

use flowcrypt.com/shared-tenant-fes/ instead of flowcrypt.com/api

I've added changes. As I understand, the backend is not ready yet.

<-- 404 Not Found https://flowcrypt.com/shared-tenant-fes/help/feedback

please also respect the naming of potentialCustomUrlFes vs sharedTenantFes, both of which are instances of the same class called ExternalService / ExternalServiceXxx (instead of previously EnterpriseServer)

Not sure about that. I can't find such names.

[tomholub]

<-- 404 Not Found https://flowcrypt.com/shared-tenant-fes/help/feedback

Only client configuration and password protected messages are implemented for now. That means, /help/feedback still has to use original url, and ACRA reports also.

[tomholub]

use flowcrypt.com/shared-tenant-fes/ instead of flowcrypt.com/api

I've added changes. As I understand, the backend is not ready yet.

It is ready except for feedback and acra endpoints.
The client configuration for our existing customers is not leaded yet, only one sample domain is loaded.
Password protected messages should work, but I haven't tested it yet - please test it.

<-- 404 Not Found https://flowcrypt.com/shared-tenant-fes/help/feedback

please also respect the naming of potentialCustomUrlFes vs sharedTenantFes, both of which are instances of the same class called ExternalService / ExternalServiceXxx (instead of previously EnterpriseServer)

Not sure about that. I can't find such names.

What class contains API calls to FES? What is it called, and what are called the API request and response models when calling FES?

[DenBond7]

What class contains API calls to FES? What is it called, and what are called the API request and response models when calling FES?

I hope it's the answer

1. https://github.com/FlowCrypt/flowcrypt-android/blob/master/FlowCrypt/src/main/java/com/flowcrypt/email/jetpack/viewmodel/CheckFesServerViewModel.kt
2. https://github.com/FlowCrypt/flowcrypt-android/blob/master/FlowCrypt/src/main/java/com/flowcrypt/email/ui/activity/fragment/MainSignInFragment.kt#L524
3. https://github.com/FlowCrypt/flowcrypt-android/blob/master/FlowCrypt/src/main/java/com/flowcrypt/email/jetpack/viewmodel/ClientConfigurationViewModel.kt#L39-L42
4. https://github.com/FlowCrypt/flowcrypt-android/blob/master/FlowCrypt/src/main/java/com/flowcrypt/email/api/retrofit/FlowcryptApiRepository.kt#L60-L69
5. https://github.com/FlowCrypt/flowcrypt-android/blob/master/FlowCrypt/src/main/java/com/flowcrypt/email/jetpack/workmanager/HandlePasswordProtectedMsgWorker.kt#L186-L198
6. https://github.com/FlowCrypt/flowcrypt-android/blob/master/FlowCrypt/src/main/java/com/flowcrypt/email/util/GeneralUtil.kt#L432

[tomholub]

Thank you - we will need some updates for clarity. We have FES servers now at two possible locations, one is at fes.domain.com (possibly, if admin set it up, must be used if present) and one is always at flowcrypt.com/shared-tenant-fes. So we need to distinguish them.

And we have no more FlowCryptComApi except for feedback and acra.

Therefore, for example:

• generateFesUrl should be called generatePotentialCustomFesUrl
• CheckFesServerViewModel should be called CheckCustomUrlFesServerViewModel
• checkFesServerAvailability should be called checkCustomUrlFesServerAvailability

In this code:

  override suspend fun getClientConfiguration(
    context: Context,
    fesUrl: String?,
    idToken: String
  ): Result<ClientConfigurationResponse> =
    withContext(Dispatchers.IO) {
      val apiService = ApiHelper.getInstance(context).retrofit.create(ApiService::class.java)
      getResult(context = context) {
        if (fesUrl != null) {
          apiService.getClientConfigurationFromFes(fesUrl = fesUrl)
        } else {
          apiService.getClientConfigurationFromFlowCryptComBackend(authorization = "Bearer $idToken")
        }
      }
    }

• fesUrl should be called customFesUrl
• then no need for if/else, instead apiService.getClientConfigurationFromFes(fesUrl = customFesUrl ?? SHARED_TENANT_FES_URL)
• getClientConfigurationFromFlowCryptComBackend should be removed

Similarly with password encrypted messages and so on.

What I'm listing here is probably just the tip of the iceberg.

[DenBond7]

then no need for if/else, instead apiService.getClientConfigurationFromFes(fesUrl = customFesUrl ?? SHARED_TENANT_FES_URL)

It means we don't need to use idToken here. Right?