rich text messages drafts are broken

[tomholub]

1. create a new secure message on Firefox
2. switch to rich text (pgp/mime) - must be on firefox, then click the "chevron" icon next to send button, and choose rich text (pgp/mime)
3. start composing, a draft will get saved
4. close the window
5. open the draft

It's broken. The issue is on the opening side, not recognizing the draft. It's possible the sending side will still have to be improved, too - normally we add "draft tags" that make the content script recognize it's a draft when opening.

[vnikolaou]

@tomholub , @limonte

tomholub >>:"..npm run-script run_firefox or by manually adding an unpacked extension into your firefox profile...."

Running pm run-script run_firefox throws an error locally:

Running web extension from /Users/vnik/Projects/FlowCrypt/flowcrypt-browser/build/firefox-consumer
s: The request "/Users/vnik/.mozilla/firefox/flowcrypt-dev" profile name cannot be resolved to a profile path

Also for unpacked version.. I am not sure what file/folder to install on Firefox for dev mode (as in chrome). It seems that Firefox gets xpi but we have only folder (build/firefox_consumer??) which cannot be selected for import . How can i do that?

[tomholub]

On about:addons choose cog -> debug addons, then Load temporary addon. Point it either at the firefox-consumer folder or the manifest inside of it. Let me know if this works.

[tomholub]

@tomholub , @limonte

tomholub >>:"..npm run-script run_firefox or by manually adding an unpacked extension into your firefox profile...."

Running pm run-script run_firefox throws an error locally:

Running web extension from /Users/vnik/Projects/FlowCrypt/flowcrypt-browser/build/firefox-consumer
s: The request "/Users/vnik/.mozilla/firefox/flowcrypt-dev" profile name cannot be resolved to a profile path

Also for unpacked version.. I am not sure what file/folder to install on Firefox for dev mode (as in chrome). It seems that Firefox gets xpi but we have only folder (build/firefox_consumer??) which cannot be selected for import . How can i do that?

To load this way, you could try to create a new profile on firefox ui, but during creation make sure to choose profile folder manually and put it in that location. That could work.

[vnikolaou]

On about:addons choose cog -> debug addons, then Load temporary addon. Point it either at the firefox-consumer folder or the manifest inside of it. Let me know if this works.

Yes, a bit different in my version till you find it, but practically the same..

[vnikolaou]

@tomholub , Okay, so following the description, i closed the secure message compose popup after typing a small message with subject, body and recipient.
Then i am trying to open the draft, and i am seeing:

Then opening on the link 'Open draft1'. (the 1 is mine... while debugging) .. the secured popup opens with the message inside. Where does it break?

[tomholub]

Need to make sure to have rich text enabled

When I tested it now, it didn't show anything at all:

When I tested it earlier, it showed encrypted pgp/mime attachments (which contain the actual message text - this is pgp/mime since you enabled rich text, as opposed to pgp/inline which is the simple text) without a way to view the draft content:

[vnikolaou]

Okay. I duplicated. it. it seems that i hadn't actually clicked on the 'Rict text' option

[vnikolaou]

@tomholub , i have been trying to find out where it breaks but seems to be some callback that creates the issue. I have put debug statements in many places. Is there any clue where to search for? Maybe the person who did that?

[tomholub]

You can probably fix it by saving rich text drafts in simple text format, so that it's same as simple text drafts. It's not a perfect fix, because it will lose the rich text, but it's better than what we have now.

Other possibility is to continue saving the drafts in rich text, but find a way for the content script that looks for drafts to recognize that it's a draft. It seems the rich text version is missing the draft "tag" that the content script is looking for, and replaces it with the "open draft" button. Adding that in will get you closer to fixing it.