removing testdata.json

[tomholub]

from @bilalashraf123

There are now two test JSON files i.e. "testdata.json" and "test-secrets.json". It is not clear which files covers which area of tests.

---

testdata.json is checked into the repository, test-secrets.json is not.
Therefore when the item is sensitive (customer information or live credentials), it goes into test-secrets.json. Else it goes into testdata.json.

Actually, I may want to remove testdata.json completely and have non-sensitive fields declared in code.

[martgil]

Hi @tomholub,

If the testdata.json was removed should we move its content somewhere or maybe in the test-secrets.json?

[tomholub]

On a second look, I think it's good as-is - let's leave it.

[rrrooommmaaa]

Actually, I may want to remove testdata.json completely and have non-sensitive fields declared in code.

@tomholub Yeah, I have to admit, that I moved a lot of test key material (public/private keys) to test/tooling/consts.ts. It was convenient to have these "ready-to-use" constants. On the other hand, we previously did some async transformations with KeyInfo in testdata.json with lazy init and all (As far as I understand, there is no need for that anymore). The pros of having the JSON file is that it's pure JSON, no code attached (whatsoever).
Ideally, we should merge these two files into one.

[tomholub]

If merging to one, do you prefer them as code or as a json file?

I prefer code, to reduce the friction of loading from a json file, and for flexibility.

[rrrooommmaaa]

Yes, to test/tooling/consts.ts would be easier,

[tomholub]

@martgil you may take the contents of testdata.json and move it to the file Roman suggested as a constant, then remove that file. Then make tests use that constant instead of testdata.json.

[martgil]

Got it Tom! Working on it asap, Thanks!