messages on live test gmail account missing

[tomholub]

This may possibly be caused by one of the updates that deletes last message in conversation - or similar - possibly it could have gradually deleted all messages by mistake?

In this issue, let's try to identify the offending code and remove it.

Then in a follow up PR me or someone will re-populate the inbox and do a backup of it somehow before we run more tests.

Or maybe we ensure the emails are present (or upload them) before each test.

[tomholub]

To be fair, when debugging other brokenness, on my first test it seemed to log in ok (with a backup loaded from inbox). On my second test, the backup was missing. Unsure if this is coincidence, that the backup was the last email to be destroyed just as I was testing it, or if I helped it somehow.

[tomholub]

I may like the idea that we would have a method to ensure message is present, or upload it, on start of the gmail test. Something like this:

    // broken - https://github.com/FlowCrypt/flowcrypt-browser/issues/3929
    ava.default.skip('mail.google.com - decrypt message in offline mode', testWithBrowser('ci.tests.gmail', async (t, browser) => {
      const gmailPage = await BrowserRecipe.openGmailPage(t, browser);
+     await ensureMessagePresent('message-export-15f84afa553d8a83.json');
      await gmailPage.type('[aria-label="Search mail"]', 'encrypted email for offline decrypt');
      await gmailPage.press('Enter'); // submit search
      await Util.sleep(2); // wait for search results
      await gmailPage.page.setOfflineMode(true); // go offline mode
      await gmailPage.press('Enter'); // open the message

This ensureMessagePresent method would check for presence of message with Gmail API, by subject. If the message is missing, parse the raw mime out of the supplied file (message-export-15f84afa553d8a83.json) and store upload it to the mail server, then verify presence again.

We already use Gmail API in tests to clear out drafts, so it's not a big stretch to do this, and would hopefully therefore be robust to unwanted state changes on the email account.

[limonte]

Oops, this sucks. This is indeed most probably caused by my changes 😭

The deletion of messages from inbox has happened here:

  public static emptyDrafts = async (gmailPage: ControllablePage) => {
    await Util.sleep(1);
    await gmailPage.waitAndClick('[data-tooltip="Drafts"]');
    await Util.sleep(1); // <- instead of 1s sleep, there should be more robust line ensuring that we're actually in drafts
    await gmailPage.page.keyboard.press('*');
    await gmailPage.page.keyboard.press('a'); // Select all
    await Util.sleep(.5);
    await gmailPage.page.keyboard.press('#'); // Delete
  }

And then deleted messages were erased by the emptyTrash helper.

---

Actions:

• remove the emptyTrash helper, I implemented it because I suspected the wrong reason for flaky test failure.
• change the emptyDrafts helper to either ensure that we're in the Drafts section before deleting messages or use Gmail API.

[limonte]

Now I feel even more stupid 🤦🤦🤦 There's already implemented deleteAllDraftsInGmailAccount method which uses Gmail API.

Note to myself: track PRs by other people more carefully.

[limonte]

@tomholub please let me know if you also expect me to do this

Then in a follow up PR me or someone will re-populate the inbox and do a backup of it somehow before we run more tests.

or assign another person, thanks!

[tomholub]

Do you have access to flowcrypt.compatibility email? The messages should be there - you should be able to find them, although it won't be that easy. When we reference them by subject in the tests, you should be able to find them that way. When we reference them by content in the tests, you may need to go one by one until you find them.

To find each message easier, take advantage of these labels:

Based on the character of the test (signed, encrypted, or a particular client that sent it) you should be able to find the source message by going through messages labeled in a certain way on the compatibility account.

Thanks!