Thunderbird signed + encrypted message: "..." instead of actual subject

[limonte]

While working on #3941 I sent 3 types of messages to ci.tests.gmail@flowcrypt.dev:

• signed html (all good)
• signed text (all good)
• signed + encrypted html (faced issues)

Here's how it looks like in Thunderbird:

And here's how it looks in FlowCrypt:

[tomholub]

This used to at least render the subject inside the message body, but I'm not seeing it on your screenshot. I wonder why.

This code:

      if (decoded.subject && isEncrypted && (!plainSubject || !Mime.subjectWithoutPrefixes(plainSubject).includes(Mime.subjectWithoutPrefixes(decoded.subject)))) {
        // there is an encrypted subject + (either there is no plain subject or the plain subject does not contain what's in the encrypted subject)
        decryptedContent = this.getEncryptedSubjectText(decoded.subject, isHtml) + decryptedContent; // render encrypted subject in message
      }

[tomholub]

Thank you for noticing

[limonte]

The issue is happening when this option is on (it's on by default when the user clicks "Require encryption"):

[tomholub]

Yup. My comment above should still hold - we have code in place to deal with this, but it no longer works. Presumably, after Thunderbird was refactored this year, they send the subject in a bit different format and we no longer recognize it.