Handle "Primary key is expired" error when verifying signing key

[sosnovsky]

I noticed many Primary key is expired errors reported from browser extension.
Seems like they're not handled:

Error: Primary key is expired
at PublicKey.verifyPrimaryKey (chrome-extension://EXTENSION_ID/lib/openpgp.js:18218:15)
at async PublicKey.getSigningKey (chrome-extension://bnjglocicdkmhmoohhfkfkbbkejdhdgc/lib/openpgp.js:18082:7)
at async chrome-extension://bnjglocicdkmhmoohhfkfkbbkejdhdgc/lib/openpgp.js:20148:11

### Catch.reportErr calling stack ###
# at Catch.formatExceptionForReport (chrome-extension://bnjglocicdkmhmoohhfkfkbbkejdhdgc/js/content_scripts/webmail_bundle.js:287:94)
# at Catch.onErrorInternalHandler (chrome-extension://bnjglocicdkmhmoohhfkfkbbkejdhdgc/js/content_scripts/webmail_bundle.js:85:33)
# at Catch.reportErr (chrome-extension://bnjglocicdkmhmoohhfkfkbbkejdhdgc/js/content_scripts/webmail_bundle.js:101:22)
# at OpenPGPKey.verify (chrome-extension://bnjglocicdkmhmoohhfkfkbbkejdhdgc/js/content_scripts/webmail_bundle.js:5850:27)
# at async MsgUtil.verifyDetached (chrome-extension://bnjglocicdkmhmoohhfkfkbbkejdhdgc/js/content_scripts/webmail_bundle.js:4918:20)
# at async verify (chrome-extension://bnjglocicdkmhmoohhfkfkbbkejdhdgc/js/content_scripts/webmail_bundle.js:13771:40)
# at async MessageRenderer.processMessageWithDetachedSignatureFromRaw (chrome-extension://bnjglocicdkmhmoohhfkfkbbkejdhdgc/js/content_scripts/webmail_bundle.js:13777:49)
# at async RenderRelay.processor (chrome-extension://bnjglocicdkmhmoohhfkfkbbkejdhdgc/js/content_scripts/webmail_bundle.js:13697:30)
#
# url: https://mail.google.com/mail/u/0/#inbox
#
######################

Error: Primary key is expired
at PublicKey.verifyPrimaryKey (chrome-extension://EXTENSION_ID/lib/openpgp.js:18218:15)
at async PublicKey.getSigningKey (chrome-extension://bnjglocicdkmhmoohhfkfkbbkejdhdgc/lib/openpgp.js:18082:7)
at async chrome-extension://bnjglocicdkmhmoohhfkfkbbkejdhdgc/lib/openpgp.js:20148:11

### Catch.reportErr calling stack ###
# at Catch.formatExceptionForReport (chrome-extension://bnjglocicdkmhmoohhfkfkbbkejdhdgc/js/content_scripts/webmail_bundle.js:287:94)
# at Catch.onErrorInternalHandler (chrome-extension://bnjglocicdkmhmoohhfkfkbbkejdhdgc/js/content_scripts/webmail_bundle.js:85:33)
# at Catch.reportErr (chrome-extension://bnjglocicdkmhmoohhfkfkbbkejdhdgc/js/content_scripts/webmail_bundle.js:101:22)
# at OpenPGPKey.verify (chrome-extension://bnjglocicdkmhmoohhfkfkbbkejdhdgc/js/content_scripts/webmail_bundle.js:5850:27)
# at async MsgUtil.decryptMessage (chrome-extension://bnjglocicdkmhmoohhfkfkbbkejdhdgc/js/content_scripts/webmail_bundle.js:4981:35)
# at async MessageRenderer.renderCryptoMessage (chrome-extension://bnjglocicdkmhmoohhfkfkbbkejdhdgc/js/content_scripts/webmail_bundle.js:13801:28)
# at async MessageRenderer.processEncryptedMsgAttachment (chrome-extension://bnjglocicdkmhmoohhfkfkbbkejdhdgc/js/content_scripts/webmail_bundle.js:13870:28)
# at async RenderRelay.processor (chrome-extension://bnjglocicdkmhmoohhfkfkbbkejdhdgc/js/content_scripts/webmail_bundle.js:13697:30)
#
######################

[sosnovsky]

All your proposals look good:

• show error modal saying that user's primary key is expired
• if user's keys are managed with EKM - show message about contacting admin
• if user can manage keys - show button Manage my keys which opens chrome-extension://..../chrome/settings/index.htm and there users will be able to generate or import new key

[sosnovsky]

@ioanmo226 seems like you've mentioned another Mart :)

@martgil can you please check previous message of Ioan, thanks!

[martgil]

Hi @ioanmo226, I tried to replicate it too using the methodologies I thought would trigger the error above, but my attempts didn’t result in anything positive.

@sosnovsky, do you have any information on whether you have been constantly getting this error, or has it ever been reported by a user? Is it a signed-only message?

[sosnovsky]

I noticed such error in reported exceptions, didn't occur for me.
Error stack mentions MsgUtil.verifyDetached, probably need to use sign-only messages for reproducing.

[martgil]

Got it - I’ll try again. This information should be sufficient to reproduce this, hopefully.

[martgil]

Bad news: I haven't been able to reproduce this issue despite several attempts using all the possible methods I can think of. Tests including a key that is about to expire don't generate such stack traces for me either.

[sosnovsky]

I checked our exception reports from the latest extension version - these errors are still present, but there are fewer of them now. I'll move this issue to cannot reproduce milestone, and if it'll disappear from our exception reports - will close it later.

Thanks for checking and reproduce attempts!