Initial version of Squire integration

[limonte]

Closes #1861

@tomholub the PR is mostly ready. If I implemented something totally wrong, let me know. I'll polish the remaining details (e.g. height of the reply iframe overflows) tomorrow.

[tomholub]

Very good. Some notes / suggestions below.

Because I didn't want to make 30 comments: since we only use squire in compose.htm, I would only include it there. Only libraries that have a potential to be used anywhere (like sweetalert) would go into every htm file.

Also, I'll have to look into how we process images (either when sending, or when receiving) because the image doesn't get rendered on the other end (doesn't properly pass sanitization).

[limonte]

Because I didn't want to make 30 comments: since we only use squire in compose.htm, I would only include it there. Only libraries that have a potential to be used anywhere (like sweetalert) would go into every htm file.

Done, thanks!

[tomholub]

For the failing test, it looks like it just wants a .trim() somewhere:

I would not mind to .trim() the value right in the test itself, because it doesn't look like the newline will hurt anything, but will leave it up to you to investigate.

[limonte]

@tomholub while working on the height overflowing, I noticed quite a nasty issue: fastmail/Squire#374

Let's see if it'll be fixed on the Squire side. If not, then we'll need to come up with some workarounds.

[tomholub]

@tomholub while working on the height overflowing, I noticed quite a nasty issue: neilj/Squire#374

Let's see if it'll be fixed on the Squire side. If not, then we'll need to come up with some workarounds.

Out of curiosity, try this fork: https://github.com/ProtonMail/Squire

[tomholub]

@tomholub while working on the height overflowing, I noticed quite a nasty issue: neilj/Squire#374
Let's see if it'll be fixed on the Squire side. If not, then we'll need to come up with some workarounds.

Out of curiosity, try this fork: https://github.com/ProtonMail/Squire

Sorry, no need - I looked at the code diff and it doesn't look relevant.

[limonte]

For the failing test, it looks like it just wants a .trim() somewhere:

I would not mind to .trim() the value right in the test itself, because it doesn't look like the newline will hurt anything, but will leave it up to you to investigate.

Done, thanks 👍

[limonte]

The PR is ready for review. Please let me know your decision on how to process inline images. Also, I'd appreciate if you help me with #2390 (comment)

[tomholub]

I fixed the images. I suspect there may still be problems in special cases like images in quoted content, images in draft and so on. We'll evaluate and test these one by one, and add automated tests too.