Clean drafts before each GMail test - #3320
Merged
Merged
Conversation
Contributor
Author
@tomholub I suggest to extract google token like this and clear the drafts using it (if that's what you meant) |
tomholub
reviewed
Jan 16, 2021
| } | ||
| } | ||
|
|
||
| public getFromLocalStorage = async (keys: string[]): Promise<any> => { |
Collaborator
There was a problem hiding this comment.
Nice!! I did not know this was possible. This is an amazingly elegant solution.
Contributor
Author
There was a problem hiding this comment.
Can we use https://www.npmjs.com/package/googleapis package to access gmail api?
Collaborator
There was a problem hiding this comment.
Sure, I'm pretty liberal with adding deps to the test infrastructure.
Contributor
Author
|
This version requests cleanup on each |
rrrooommmaaa
marked this pull request as ready for review
January 17, 2021 09:39
tomholub
added a commit
that referenced
this pull request
Jan 18, 2021
* issue 3257 rename att to attachment - initial * issue #3315 Clean drafts before each GMail test (#3320) * extract google token * tslint fix * clean GMail drafts * Added googleapis package * issue 3257 rename att to attachment - initial * renamed att to attachment * renamed att to attachment * renamed att to attachment * renamed att to attachment * renamed att to attachment Co-authored-by: Tom J <tom@holub.me> Co-authored-by: Roman <rrrooommmaaa@mail.ru> Co-authored-by: bilal.ashraf@gmail.com <bilal.ashraf@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts google token and deletes all drafts on the account
close #3315