Skip to content

issue 4251 password policy - #4252

Merged
rrrooommmaaa merged 8 commits into
masterfrom
issue-4251-password-policy
Jan 13, 2022
Merged

rrrooommmaaa merged 8 commits into
masterfrom
issue-4251-password-policy

Conversation

@tomholub

@tomholub tomholub commented Jan 13, 2022 •

Copy link
Copy Markdown
Collaborator

This PR adds a password policy for messages based on whether FES is used or not

close #4251


Tests (delete all except exactly one):

  • Tests updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@tomholub

tomholub commented Jan 13, 2022 •

Copy link
Copy Markdown
Collaborator Author

image

image

@tomholub tomholub left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM provided that tests pass

Comment thread extension/chrome/elements/compose.ts
@tomholub
tomholub marked this pull request as draft January 13, 2022 17:49
@tomholub
tomholub marked this pull request as ready for review January 13, 2022 19:09
@tomholub

Copy link
Copy Markdown
Collaborator Author

@rrrooommmaaa this is now ready as well

@rrrooommmaaa
rrrooommmaaa merged commit 775bc30 into master Jan 13, 2022
@rrrooommmaaa
rrrooommmaaa deleted the issue-4251-password-policy branch January 13, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

security - add password policy when sending password-protected message

2 participants