issue 4369 choose valid key for sending - #4372
Conversation
|
also todo - need to ensure there is no more |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
@rrrooommmaaa do you think you could review this today? If yes, I'll wait with the release for the review. If not, I'd do a release and tell the customer to only test on evaluation environment for now. |
Sure, I'll take a look |
|
(for me - need to look at |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@rrrooommmaaa we're green. Tomorrow please have another look. Thanks! |
rrrooommmaaa
left a comment
There was a problem hiding this comment.
I outlined my concerns and ideas
…owcrypt-browser into issue-4369-choose-right-key
tomholub
left a comment
There was a problem hiding this comment.
re-review. looks good, will file one more issue and merge this
| return new Attachment({ name: `flowcrypt-backup-${this.view.acctEmail.replace(/[^A-Za-z0-9]+/g, '')}.asc`, type: 'application/pgp-keys', data: Buf.fromUtfStr(armoredKey) }); | ||
| private asBackupFile = (prv: KeyInfoWithIdentity) => { | ||
| return new Attachment({ | ||
| name: `flowcrypt-backup-${this.view.acctEmail.replace(/[^A-Za-z0-9]+/g, '')}-${prv.id}.asc`, |
There was a problem hiding this comment.
I updated backups to use one file per key, and include fingerprint in each filename.
This PR ensures that the extension always works with a valid key when available, even if first received key is revoked.
close #4369 - choose valid key
issue #4376 - KeyIdentity.type renamed to KeyIdentity.family
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):