#5308 Fix the error when sending password-protected emails that contain emojis - #5321
Merged
sosnovsky merged 25 commits intoOct 3, 2023
Conversation
martgil
marked this pull request as draft
July 23, 2023 09:26
…ipient-email-containing-emoji
…ipient-email-containing-emoji
martgil
marked this pull request as ready for review
July 29, 2023 06:53
Collaborator
Author
|
Manual test: Screencast.from.2023-07-29.14-57-12.webm |
Collaborator
Author
|
@sosnovsky ready for review. thank you. |
…ipient-email-containing-emoji
sosnovsky
reviewed
Jul 31, 2023
sosnovsky
left a comment
Collaborator
There was a problem hiding this comment.
Works well 👍 Just a couple small improvements needed
martgil
marked this pull request as draft
July 31, 2023 10:51
martgil
commented
Aug 2, 2023
martgil
marked this pull request as ready for review
August 2, 2023 07:24
Collaborator
Author
|
ready for review again. thank you. |
martgil
marked this pull request as draft
August 2, 2023 08:10
Collaborator
Author
|
marking back to draft state a better solution can be discussed at #5308 |
…l-sending-issue-for-recipient-email-containing-emoji
martgil
marked this pull request as ready for review
September 27, 2023 11:43
Collaborator
Author
|
@sosnovsky Ready for review. thank you! |
sosnovsky
reviewed
Sep 28, 2023
martgil
marked this pull request as draft
September 28, 2023 11:50
martgil
marked this pull request as ready for review
September 30, 2023 11:58
Collaborator
Author
|
@sosnovsky ready for review. thank you! |
sosnovsky
reviewed
Sep 30, 2023
…l-sending-issue-for-recipient-email-containing-emoji
sosnovsky
reviewed
Oct 2, 2023
sosnovsky
reviewed
Oct 3, 2023
Collaborator
Author
|
@sosnovsky This should be all good and ready to merge. thanks! |
sosnovsky
deleted the
issue-5308-fix-email-sending-issue-for-recipient-email-containing-emoji
branch
October 3, 2023 07:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
.stripEmojis()to strip out emojis of the recipient contact's name.close #5308
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):