crash when moving email to trash

[tomholub]

[tomholub]

[tomholub]

It's in a catch block but wasn't caught - is that because it's an ObjC exception?

[tomholub]

      [NSException raise:ASCollectionInvalidUpdateException format:@"%@: %@", [responsibleDataSource class], e.reason];

[ivan-ushakov]

It's in a catch block but wasn't caught - is that because it's an ObjC exception?

Yes, same thing as Realm exceptions. We can not catch them with do - catch. Only with objc code and @try.

[tomholub]

It would be good to use this: https://stackoverflow.com/questions/32758811/catching-nsexception-in-swift everywhere.

[tomholub]

Could call it ObjC.catch to be used as follows:

do {
    try ObjC.catch {
       /* calls that might throw an NSException */
    }
} catch {
    print("An error ocurred: \(error)")
}

But don't know if it can interface with async/await calls inside? One way or another, we should find a way to do this, for sanity.

[ivan-ushakov]

It would be good to use this: https://stackoverflow.com/questions/32758811/catching-nsexception-in-swift everywhere.

Having this everywhere will make code looks verbose. We could use it in potential dangerous places but wrapping each objc function/method is too much.

[tomholub]

It would be good to use this: https://stackoverflow.com/questions/32758811/catching-nsexception-in-swift everywhere.

Having this everywhere will make code looks verbose. We could use it in potential dangerous places but wrapping each objc function/method is too much.

That would be verbose, yes. The issue is that almost anything can potentially throw ObjC exception. MailCore - ObjC. Gmail API - ObjC. Texture - ObjC.

Do we necessarily have to catch it exactly on the first boundary from ObjC to Swift? Or could it be later? Best would be if we only had to do it once per Task - then it's not verbose.

fun handle() {
  Task {
    do {
      try ObjC.catch {
        try await thisCanThrowSwift()
        try await thisCallsMethodThatCallsMethodThatCanThrowObjc()
        thisCanTrhowObjC()
        someOtherCode()
      }
    } catch {
      handle(error)
    }
  }
}

[tomholub]

I see it won't be so easy - let's discuss general ObjC catching separately in #1077. I'll hide the comments here.