NO_MDC (not integrity protected) message produces empty screen

[tomholub]

@tomholub, I have retested the latest master branch and there is only one that is not working properly at the moment.

This message has no description at all, where it should be flagged as NO_MDC - Missing integrity checks

Originally posted by @martgil in #704 (comment)

[tomholub]

@martgil can you confirm we have a message like this on e2e account and you can reproduce it there?

[martgil]

Hi @tomholub, Yes sir, the message is also included on the e2e account. The same happens for the e2e account - with the latest ios build.

[tomholub]

There's a test added in #1154 that needs to also be updated once fixed

[ivan-ushakov]

@tomholub
Am I right that we just show alert about MDC and not decrypt message at all?

[tomholub]

We should render the error into the message body just like we do for other decrypt errors - no modals.

See related #1143 - we don't want a modal here (except for collecting pass phrase), we want to render the error into the body.

And set badge to "decrypt error" in both cases.

[ivan-ushakov]

@tomholub
Looks like Endpoints.parseDecryptMsg does not work right and returns plain type. I will try to find what is wrong.

[ivan-ushakov]

} else {
  console.log('decrypt error = ' + decryptRes.error.type + ', subject = ' + subject);
  decryptRes.message = undefined;
  sequentialProcessedBlocks.push({
    type: 'decryptErr',
    content: decryptRes.error.type === DecryptErrTypes.noMdc ? decryptRes.content! : rawBlock.content,
    decryptErr: decryptRes,
    complete: true
  });
}

Here I get this - decrypt error = key_mismatch, subject = not integrity protected - should show a warning and not decrypt automatically. So error is key_mismatch, not noMdc

[tomholub]

If that's true, then key_mismatch should be showing a key_mismatch error, not empty result.

Should compare the behavior to Android app and browser extension, for that message.