Can't fetch mails - SWIFT TASK CONTINUATION MISUSE

[sosnovsky]

App gives SWIFT TASK CONTINUATION MISUSE error when trying to open home screen:

Originally posted by @sosnovsky in #700 (comment)

[tomholub]

@ivan-ushakov I've reverted the last async/await change with 8abb46b . Please take a look.

[Kharchevskyi]

had the same issue in #657 after pulling master.

Is it possible to postpone #404 for inbox before #608?

[tomholub]

Are you able to finalize the threads in the next week or so? I was going to schedule it for later, since we are doing refactoring these days / knowing it would produce conflicts (that's why I put threads in later milestone). But if you could get it done in about a week then we could wait with the other stuff.

[tomholub]

@ivan-ushakov to work on async/await you could look into PubLookup and all the classes it calls instead. I'll make a separate issue.

[tomholub]

@Kharchevskyi btw is the task continuation problem something that is easily avoidable during coding or PR reviews? Or do we need to rely on manual testing?

[ivan-ushakov]

Yes, my bad. This error happens when we execute async function while the first continuation didn't finish. Here is wrong piece of code:

for identifier in messageIdentifiers {
    messages.append(try await fetchFullMessage(with: identifier))
}

[ivan-ushakov]

@tomholub
I think I can fix this today. Are you Ok with returning my code back if it will be fixed?

[tomholub]

Of course, the only thing is that it will cause some merge conflicts for Anton. But I think that is unavoidable. After this though, we'll postpone async/await refactoring of the Gmail API so that he can work on message threads in peace, and focus on refactoring other parts instead.

[ivan-ushakov]

For the history. Problem was a bit more complex. I used weak gmailService property inside continuation and haven't checked this this property is computational, so we create new gmailService instance each time. This leads to nil value in weak property so continuation never resume.