Added new spec for checking sent message after wrong pass phrase - #1027
Merged
Merged
Conversation
tomholub
requested changes
Nov 17, 2021
tomholub
left a comment
Collaborator
There was a problem hiding this comment.
Comments below - for the ones that are for another PR, I'll mark them as resolved and file another issue. The ones that are for this PR will be left open here.
This was referenced Nov 17, 2021
tomholub
approved these changes
Nov 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains new spec for checking sent message after setting wrong pass phrase
Added faker to package.json file
added generation fake data for subject for new compose email
close #861
Tests
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):