Skip to content

Replace Combine Future with async/await if any left - #1166

Merged
tomholub merged 1 commit into
masterfrom
feature/issue-1058
Dec 5, 2021
Merged

Replace Combine Future with async/await if any left#1166
tomholub merged 1 commit into
masterfrom
feature/issue-1058

Conversation

@ivan-ushakov

@ivan-ushakov ivan-ushakov commented Dec 4, 2021

Copy link
Copy Markdown
Contributor

close #1058


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ivan-ushakov

Copy link
Copy Markdown
Contributor Author

We still have one import Combine in ComposeViewController.swift because we use it for some UI logic.

Comment thread FlowCrypt/Controllers/Compose/ComposeViewController.swift
Comment thread FlowCrypt/Controllers/Threads/ThreadDetailsViewController.swift
@tomholub
tomholub enabled auto-merge (squash) December 4, 2021 21:30
@tomholub

tomholub commented Dec 4, 2021

Copy link
Copy Markdown
Collaborator

I'm good to merge this, but some tests are unhappy.

@ivan-ushakov

ivan-ushakov commented Dec 5, 2021

Copy link
Copy Markdown
Contributor Author

I'm good to merge this, but some tests are unhappy.

It works fine locally. We already have issue #1164 for this test.

@tomholub
tomholub merged commit 3bf2ac3 into master Dec 5, 2021
@tomholub
tomholub deleted the feature/issue-1058 branch December 5, 2021 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

replace Combine Future with async/await if any left

2 participants