#1091 add google id tokens refresh - #1225
Merged
Merged
Conversation
sosnovsky
marked this pull request as ready for review
December 14, 2021 21:28
tomholub
requested changes
Dec 15, 2021
tomholub
approved these changes
Dec 15, 2021
Comment on lines
+161
to
+164
| let googleService = GoogleUserService( | ||
| currentUserEmail: user.email, | ||
| appDelegateGoogleSessionContainer: nil | ||
| ) |
Collaborator
There was a problem hiding this comment.
We probably could/should dependency-inject this through AppContext. I'll file another issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds auto-refresh for Google id tokens.
close #1091
Tests (delete all except exactly one):
GTMAppAuthbuilt-in functionality and we're using mockGoogleUserServicein tests.To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):