Skip to content

#1222 Add id tokens refresh on expiry - #1263

Merged
tomholub merged 1 commit into
masterfrom
feature/issue-1222-id-token
Dec 30, 2021
Merged

tomholub merged 1 commit into
masterfrom
feature/issue-1222-id-token

Conversation

@sosnovsky

@sosnovsky sosnovsky commented Dec 30, 2021 •

Copy link
Copy Markdown
Collaborator

This PR adds minExpiryDuration parameter for fetching id tokens.

close #1222


Tests (delete all except exactly one):

  • Difficult to test (explain why) - tokens are fetched from Google API

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@sosnovsky
sosnovsky requested a review from tomholub December 30, 2021 15:27
@tomholub
tomholub merged commit e80ea25 into master Dec 30, 2021
@tomholub
tomholub deleted the feature/issue-1222-id-token branch December 30, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

retrieve id token (or reauth) when sending password-protected message

2 participants