Skip to content

Handle error if key was not submit to Attester - #1311

Merged
sosnovsky merged 7 commits into
masterfrom
feature/issue-1303-generate-key
Jan 24, 2022
Merged

Handle error if key was not submit to Attester#1311
sosnovsky merged 7 commits into
masterfrom
feature/issue-1303-generate-key

Conversation

@Kharchevskyi

@Kharchevskyi Kharchevskyi commented Jan 16, 2022 •
edited by sosnovsky
Loading

Copy link
Copy Markdown
Contributor

This PR:

  • Fixes error handling if key was not submit to Attester
  • Fix storing backup key in inbox

close #1304

Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)
  • Difficult to test (explain why)
  • Not worth testing
  • Tests will be added later (issue #...)
  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

Kharchevskyi
Kharchevskyi commented Jan 16, 2022
View reviewed changes
Comment thread FlowCrypt/Controllers/Setup/SetupGenerateKeyViewController.swift Outdated
Kharchevskyi
Kharchevskyi commented Jan 16, 2022
View reviewed changes
Comment thread FlowCrypt/Functionality/Services/ApiCall.swift
Kharchevskyi
Kharchevskyi commented Jan 19, 2022
View reviewed changes
Comment thread FlowCrypt/Functionality/Mail Provider/Message Gateway/Imap+send.swift
@Kharchevskyi

Kharchevskyi commented Jan 20, 2022

Copy link
Copy Markdown
Contributor Author

@tomholub can you please check comments in this pr

@tomholub tomholub mentioned this pull request Jan 21, 2022
Open
tomholub
tomholub approved these changes Jan 21, 2022
View reviewed changes

@tomholub tomholub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me overall

Comment thread FlowCrypt/Controllers/Setup/SetupGenerateKeyViewController.swift Outdated
Comment thread FlowCrypt/Functionality/Error Handling/KeyServiceErrorHandler.swift Outdated
Comment thread FlowCrypt/Functionality/Mail Provider/Message Gateway/Imap+send.swift
Comment thread FlowCrypt/Functionality/Services/ApiCall.swift Outdated
tomholub
tomholub previously approved these changes Jan 21, 2022
View reviewed changes
Comment thread FlowCrypt/Controllers/Setup/SetupGenerateKeyViewController.swift
@Kharchevskyi
Kharchevskyi marked this pull request as ready for review January 21, 2022 13:24
@tomholub

tomholub commented Jan 23, 2022

Copy link
Copy Markdown
Collaborator

@Kharchevskyi please check the tests later - still not passing

sosnovsky
sosnovsky approved these changes Jan 24, 2022
View reviewed changes

@sosnovsky sosnovsky left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍

@sosnovsky
sosnovsky merged commit 38fcac3 into master Jan 24, 2022
@sosnovsky
sosnovsky deleted the feature/issue-1303-generate-key branch January 24, 2022 21:08
@Kharchevskyi Kharchevskyi mentioned this pull request Jan 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sosnovsky sosnovsky sosnovsky approved these changes
@tomholub tomholub Awaiting requested review from tomholub

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

consumer setup - the key is not backed up to inbox when creating new key

3 participants

@Kharchevskyi @tomholub @sosnovsky