Current user should be dependency-injected - #1331
Merged
Merged
Conversation
ivan-ushakov
commented
Jan 24, 2022
ivan-ushakov
commented
Jan 24, 2022
sosnovsky
reviewed
Jan 24, 2022
ivan-ushakov
marked this pull request as draft
January 24, 2022 19:20
ivan-ushakov
marked this pull request as ready for review
January 25, 2022 18:53
tomholub
reviewed
Jan 25, 2022
tomholub
reviewed
Jan 27, 2022
tomholub
left a comment
Collaborator
There was a problem hiding this comment.
Actually it doesn't look bad to me. See comments.
tomholub
reviewed
Jan 27, 2022
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #863
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):