issue 1358 remove DataService - #1359
Merged
Merged
Conversation
tomholub
commented
Feb 2, 2022
Comment on lines
+10
to
+11
| func replace(email: String, pubkey: String, idToken: String?) async throws -> String | ||
| func update(email: String, pubkey: String) async throws -> String |
Collaborator
Author
There was a problem hiding this comment.
Replace means change one pubkey to another (needs Id token). Update means upload an updated version of the same public key (same primary fingerprint) - no id token needed.
Collaborator
Author
|
@ivan-ushakov later please help me to finish this PR to compile and pass tests. Above comments will be for another issue later, just making this one functional. When ready, please request review from Roma. Thanks! (I mean later on, when you're done with whatever you're working on so you don't need to jump between tasks) |
ivan-ushakov
marked this pull request as ready for review
February 5, 2022 18:14
sosnovsky
requested changes
Feb 7, 2022
sosnovsky
left a comment
Collaborator
There was a problem hiding this comment.
Looks good with AppContextWithUser integration, it requires less parameters to be passed 👍
sosnovsky
requested changes
Feb 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removed DataService as it duplicated functionality.
close #1358
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):