Add aid for thread messages and added test for checking thread rendering - #1395
Merged
Conversation
Contributor
|
@tomholub I will fix the test on my branch |
fcvakintos
marked this pull request as ready for review
February 22, 2022 07:38
Collaborator
|
@fcvakintos can you continue on this branch? or alternatively, close this PR but use the code in your own branch? I'm hesitant to merge a PR that doesn't pass tests. |
Contributor
|
@tomholub ok, will continue on this branch |
Collaborator
|
The git history seems unhappy - we will need to do something about it before merging. Maybe squashing the history first. Otherwise not possible to review. |
tomholub
approved these changes
Mar 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds accessibility ids and add test for checking thread rendering, updated test after pushing new aids, added new methods for checking thread
close #1370
close #959
Tests
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):