Skip to content

Ignore load account tap while searching for backups - #304

Merged
tomholub merged 5 commits into
masterfrom
bugfix/issue-293-fix-for-signin
May 11, 2021
Merged

Ignore load account tap while searching for backups#304
tomholub merged 5 commits into
masterfrom
bugfix/issue-293-fix-for-signin

Conversation

@Kharchevskyi

Copy link
Copy Markdown
Contributor

close #293

Comment thread FlowCrypt/Controllers/Setup/SetupViewController.swift
@Kharchevskyi
Kharchevskyi force-pushed the bugfix/issue-293-fix-for-signin branch from 9d8a6b5 to 61495c8 Compare May 7, 2021 11:10
@tomholub

tomholub commented May 7, 2021

Copy link
Copy Markdown
Collaborator

@Kharchevskyi can you please look at the tests?

@tomholub

tomholub commented May 7, 2021

Copy link
Copy Markdown
Collaborator

I debugged the problem(s):

  1. there are 5 search expressions - and it seems we make 5 API requests to gmail. This should not be the case, it should be just one search expression and one request with 4 ORs in it.
  2. the search expressions are wrong for Gmail search. On my account I have no backups, but it downloads 137 emails! and then 73 attachments with 33mb of data
  3. this above seems to take forever, which is why we got to this UI issue in the first place (that you fixed)
  4. when it does finish, it was saying "Setup failed" which is a nonsensical error, it should have said "No backups found on this account" (I fixed)

Please address issues 1 and 2 as well

@tomholub

tomholub commented May 7, 2021

Copy link
Copy Markdown
Collaborator

Change - please just fix tests on this PR, and we can address points 1 and 2 some other time, there are more important issues before that.

@tomholub

Copy link
Copy Markdown
Collaborator

@Kharchevskyi please fix the tests when you have a chance. Thanks!

@tomholub

Copy link
Copy Markdown
Collaborator

They seemed to have passed this time - flaky

@tomholub
tomholub merged commit abb8d2e into master May 11, 2021
@tomholub
tomholub deleted the bugfix/issue-293-fix-for-signin branch May 11, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clicking Load Account while still loading causes crash

3 participants