Skip to content

Increase succintness of Future handling in Combine - #423

Merged
tomholub merged 1 commit into
masterfrom
feature/issue-402-increase-combine-succitness
Jul 29, 2021
Merged

tomholub merged 1 commit into
masterfrom
feature/issue-402-increase-combine-succitness

Conversation

@Kharchevskyi

@Kharchevskyi Kharchevskyi commented Jul 29, 2021

Copy link
Copy Markdown
Contributor

This PR adds sinkFuture as an extension to Publisher

close #402

Tests (delete all except exactly one):

  • Not worth testing

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@Kharchevskyi
Kharchevskyi requested a review from tomholub July 29, 2021 18:13

@Kharchevskyi Kharchevskyi left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tomholub tomholub left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good

@tomholub
tomholub merged commit 38b982c into master Jul 29, 2021
@tomholub
tomholub deleted the feature/issue-402-increase-combine-succitness branch July 29, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

increase succintness of Future handling

2 participants