issue 743 contacts.other search - #844
Merged
Merged
Conversation
tomholub
marked this pull request as draft
October 29, 2021 12:51
Collaborator
|
Thank you! I'll need to make it a draft, until Google approves the new scope. |
tomholub
reviewed
Nov 1, 2021
tomholub
left a comment
Collaborator
There was a problem hiding this comment.
works excellently. I've submitted the scope to google, now waiting to get approved.
Collaborator
|
For us it usually takes about a week
|
tomholub
marked this pull request as ready for review
November 3, 2021 19:41
tomholub
approved these changes
Nov 3, 2021
Collaborator
|
approved by google |
tomholub
enabled auto-merge (squash)
November 3, 2021 19:44
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds search through email addresses which are not stored in user's Gmail contacts. It also needs additional auth scope
https://www.googleapis.com/auth/contacts.other.readonly(currently it shows warning screen when user authenticates for the first time)close #743
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):