Skip to content

FEATURE: make outputResults parameter configurable#65

Merged
bwaidelich merged 11 commits into
Flowpack:mainfrom
das-nagnag:configure-output-results
Jul 15, 2024
Merged

FEATURE: make outputResults parameter configurable#65
bwaidelich merged 11 commits into
Flowpack:mainfrom
das-nagnag:configure-output-results

Conversation

@das-nagnag

Copy link
Copy Markdown
Contributor

No description provided.

@bwaidelich bwaidelich changed the title feat: make outputResults parameter configurable FEATURE: make outputResults parameter configurable Jul 15, 2024
@bwaidelich

Copy link
Copy Markdown
Contributor

Now I get you, thanks for the contribution.

I would suggest to make that an option of the queue (like executeIsolated) instead of a global configuration

@das-nagnag

Copy link
Copy Markdown
Contributor Author

Thank you for the feedback! That's a very good call, I actually didn't even think of that, my bad 😅 I'll try to implement that shortly

@bwaidelich bwaidelich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

das-nagnag added 5 commits 16 minutes ago

you know that you can collect multiple changes into one commit, right? :D

Looking great, just a mini suggestion regarding the description of the new setting

Comment thread README.md Outdated
das-nagnag and others added 2 commits July 15, 2024 15:02
@das-nagnag

Copy link
Copy Markdown
Contributor Author

das-nagnag added 5 commits 16 minutes ago

you know that you can collect multiple changes into one commit, right? :D

Looking great, just a mini suggestion regarding the description of the new setting

Yeah, sorry for all the tiny commits. My phpStorm decided today would be the perfect day to stop working properly and since I didn't have the time or energy to get it up and running again yet, I just made all the changes through githubs online editor – which is both painful and slow :D

@bwaidelich bwaidelich left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bwaidelich
bwaidelich merged commit 3cc99b5 into Flowpack:main Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants