Skip to content

feat: improve legacy map accessibility #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anthony-maio wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: improve legacy map accessibility #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52c9f56
[verified] feat: improve legacy map accessibility
anthony-maio Aug 19, 2026
5e37a69
fix: address map accessibility review
anthony-maio Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions webapp/src/assets/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,3 +171,14 @@ pre code {
html, body {
overflow-x: hidden;
}
.sr-only {
position: absolute !important;
width: 1px;
height: 1px;
padding: 0;
margin: -1px;
overflow: hidden;
clip: rect(0 0 0 0);
white-space: nowrap;
border: 0;
}
29 changes: 13 additions & 16 deletions webapp/src/components/DFMapPopup.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
<template>
<v-sheet min-width="240">
<v-sheet min-width="240" role="dialog" aria-labelledby="df-map-popup-heading">
<h2 id="df-map-popup-heading" tabindex="-1" class="text-subtitle-1 font-weight-bold px-4 pt-3">
Camera details
</h2>
<!-- TODO: if a field is unknown, prompt user to edit it -->
<div class="position-relative">
<v-img v-if="imageUrl" cover width="100%" height="150px" :src="imageUrl" class="rounded mt-5" position="top" />
<v-img v-if="imageUrl" cover width="100%" height="150px" :src="imageUrl" :alt="cameraImageAlt" class="rounded mt-5" position="top" />
<div v-if="imageUrl" class="position-absolute bottom-0 left-0 right-0 text-center text-white text-caption" style="background: rgba(0, 0, 0, 0.5);">
{{ manufacturer }} {{ manufacturer.endsWith(' LPR') ? '' : ' LPR' }}
</div>
Expand Down Expand Up @@ -57,6 +60,7 @@ import type { ALPR } from '@/types';
import { VIcon, VList, VSheet, VListItem, VBtn, VImg, VListItemSubtitle, VDivider } from 'vuetify/components';
import { useVendorStore } from '@/stores/vendorStore';
import { md5 } from 'js-md5';
import { getCameraManufacturer, getCameraOperator } from './mapAccessibility';

const props = defineProps({
alpr: {
Expand All @@ -65,13 +69,7 @@ const props = defineProps({
}
});

const manufacturer = computed(() => (
props.alpr.tags.manufacturer ||
props.alpr.tags['surveillance:manufacturer'] ||
props.alpr.tags.brand ||
props.alpr.tags['surveillance:brand'] ||
'Unknown'
));
const manufacturer = computed(() => getCameraManufacturer(props.alpr.tags) || 'Unknown');

const store = useVendorStore();
const vendorImageUrl = ref<string | undefined | null>(undefined);
Expand All @@ -85,13 +83,13 @@ const imageUrl = computed(() => {
return wikimediaImages.value?.thumbnail ?? vendorImageUrl.value;
});

const cameraImageAlt = computed(() => (
manufacturer.value === 'Unknown' ? 'Camera' : `${manufacturer.value} camera`
));

const abbreviatedOperator = computed(() => {
const operatorTagKeys = [
"operator",
"surveillance:operator"
]
const operatorTagKey = operatorTagKeys.find(key => props.alpr.tags[key] !== undefined);
if (!operatorTagKey) {
const operator = getCameraOperator(props.alpr.tags);
if (!operator) {
return undefined;
}

Expand All @@ -101,7 +99,6 @@ const abbreviatedOperator = computed(() => {
"Sheriffs Office": "SO",
};

const operator = props.alpr.tags[operatorTagKey];
for (const [full, abbr] of Object.entries(replacements)) {
if (operator.includes(full)) {
return operator.replace(full, abbr);
Expand Down
Loading