fix(security): CSPRNG password gen + gate /uploads behind auth (P1 lows) - #15
Merged
Conversation
- users.js generatePassword: use crypto.randomInt instead of Math.random for the one-time generated user password (CSPRNG, not predictable). - index.js: serve /uploads (BDA profile images) behind authMiddleware so the files can't be fetched anonymously by guessing a filename. Addresses lane 02 LOWs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: KingArthur000 <sathyaprakashelango@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
P1 leftover hardening (review lane 02 LOWs):
generatePasswordusedMath.random()— not cryptographically secure. The one-time password generated for new users is now produced withcrypto.randomInt()./uploadswas served before auth — BDA profile images were anonymously fetchable by guessing a (random-ish) filename. Now gated behindauthMiddleware(cookies are sent on same-origin<img>requests, so the authenticated SPA is unaffected).Verification
node --checkonindex.js+users.js✓npm test→ 20/20 backend tests pass.