fix(security): SSRF guard on Meta media download (Batch C) - #7
Merged
Conversation
…rects + size cap) Batch C. downloadMediaBinary fetched the Graph-API-supplied URL with the Bearer token and followed redirects, enabling SSRF to internal hosts. Now: enforce https + a Meta CDN host allowlist (fbcdn.net/whatsapp.net/facebook.com), set redirect:'error', and cap the response at 100 MB. Audit ref: REVIEW.md P0 #3 (lane 07 CRITICAL). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: KingArthur000 <sathyaprakashelango@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch C — SSRF (REVIEW.md P0 #3, lane 07 CRITICAL).
downloadMediaBinaryfetched the Graph-API-supplied URL with the Bearer token and followed redirects. Now enforces HTTPS + a Meta CDN host allowlist,redirect:'error', and a 100 MB cap. (Broadcast-link scheme check + automationdynamic_apiconstraint remain as HIGH follow-ups.)