[pull] main from spring-projects:main - #13
Merged
Merged
Conversation
FilterExpressionTextParser treated every integer literal as an Integer, so values outside the int range (for example a Long metadata id) failed with NumberFormatException at parse time. Integer literals within the int range keep producing Integer values, while larger unsuffixed literals now fall back to Long. The explicit 'l' or 'L' suffix continues to produce Long values. Fixes #4705 Signed-off-by: Lubaoshuai <128781758+Lubaoshuai@users.noreply.github.com>
`MariaDBSchemaValidator` bound the string "SCHEMA()" as a query parameter when no schema name was configured, so the table lookup evaluated as `TABLE_SCHEMA = 'SCHEMA()'` and never matched, and the column lookup bound a null schema name with the same result. With `schemaValidation` enabled and no `schemaName` set, `MariaDBVectorStore` therefore failed in `afterPropertiesSet` with `Table 'vector_store' does not exist in schema 'null'` for a table that was in fact present. Resolve the schema name once, up front, falling back to `SELECT SCHEMA()` when none is configured, and use it for both queries, for the DDL suggested on failure and for the messages that previously reported `schema 'null'`. The vector support probe also dropped the two arguments it bound to a statement that has no placeholders. The added test validates a table in the connection's default schema against a MariaDB container and fails against the previous implementation. Closes #6917 Signed-off-by: jhpark1227 <jhpark2208@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )