Skip to content

Revert Portable/BCC formatting - #828

Merged
aggarg merged 17 commits into
FreeRTOS:mainfrom
Skptak:fixBCCFormatting
Dec 7, 2023
Merged

Revert Portable/BCC formatting#828
aggarg merged 17 commits into
FreeRTOS:mainfrom
Skptak:fixBCCFormatting

Conversation

@Skptak

@Skptak Skptak commented Oct 10, 2023

Copy link
Copy Markdown
Contributor

Description

Revert the formatting on BCC ports

Test Steps

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Skptak
Skptak requested a review from a team as a code owner October 10, 2023 23:12
@codecov

codecov Bot commented Oct 10, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bcf7bda) 93.78% compared to head (ba5514c) 93.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #828   +/-   ##
=======================================
  Coverage   93.78%   93.78%           
=======================================
  Files           6        6           
  Lines        3184     3184           
  Branches      885      885           
=======================================
  Hits         2986     2986           
  Misses         91       91           
  Partials      107      107           
Flag Coverage Δ
unittests 93.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Skptak Skptak mentioned this pull request Nov 8, 2023
2 tasks

@chinglee-iot chinglee-iot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared with commit before #768
d6bccb1 | 2023-09-05 | Gaurav-Aggarwal-AWS | Fix heap address calculation issue (#781)

d6bccb1...Skptak:FreeRTOS-Kernel:fixBCCFormatting

portable/BCC/16BitDOS/PC/port.c : only revert ASM macro and ";" is missing.
portable/BCC/16BitDOS/common/port.c : only revert ASM macro

Suggest we revert the space as much as possible in these two files.

Comment thread portable/BCC/16BitDOS/PC/port.c Outdated
@sonarqubecloud

sonarqubecloud Bot commented Dec 7, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aggarg
aggarg merged commit ac7fc39 into FreeRTOS:main Dec 7, 2023
@Skptak
Skptak deleted the fixBCCFormatting branch December 19, 2023 13:06
DajanaV pushed a commit to auroralabs-loci/FreeRTOS-Kernel that referenced this pull request Dec 3, 2025
Revert Portable/BCC formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants