Revert Portable/CodeWarrior formatting - #831
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #831 +/- ##
=======================================
Coverage 93.78% 93.78%
=======================================
Files 6 6
Lines 3184 3184
Branches 885 885
=======================================
Hits 2986 2986
Misses 91 91
Partials 107 107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
chinglee-iot
left a comment
There was a problem hiding this comment.
Compared with commit before #768
d6bccb1 | 2023-09-05 | Gaurav-Aggarwal-AWS | Fix heap address calculation issue (#781)
d6bccb1...Skptak:FreeRTOS-Kernel:fixCodeWarriorFormatting
- INDENT-OFF/ON comments are removed. Suggest we add them back.
- configTICK_TYPE_WIDTH_IN_BITS is wrongly reverted. We should add it back.
| /* *INDENT-OFF* */ | ||
| #ifdef __cplusplus | ||
| extern "C" { | ||
| extern "C" { | ||
| #endif | ||
| /* *INDENT-ON* */ |
There was a problem hiding this comment.
Suggest we add back the INDENT-OFF/ON comments.
| #if( configUSE_16_BIT_TICKS == 1 ) | ||
| typedef uint16_t TickType_t; | ||
| #define portMAX_DELAY ( TickType_t ) 0xffff | ||
| #else | ||
| #error configTICK_TYPE_WIDTH_IN_BITS set to unsupported tick type width. | ||
| typedef uint32_t TickType_t; | ||
| #define portMAX_DELAY ( TickType_t ) 0xffffffffUL | ||
| #endif |
There was a problem hiding this comment.
configTICK_TYPE_WIDTH_IN_BITS is also wrongly reverted. We should add it back.
| } \ | ||
| } while( 0 ) | ||
|
|
||
| /* *INDENT-OFF* */ |
There was a problem hiding this comment.
Same suggestion for the INDENT-OFF/ON
| #ifndef PORTMACRO_H | ||
| #define PORTMACRO_H | ||
|
|
||
| /* *INDENT-OFF* */ |
There was a problem hiding this comment.
Same suggestion for INDENT-OFF/ON
|
|
||
| #ifdef __cplusplus | ||
| } | ||
| } |
There was a problem hiding this comment.
INDENT-OFF/ON suggestion.
| typedef signed char BaseType_t; | ||
| typedef unsigned char UBaseType_t; | ||
|
|
||
| #if( configUSE_16_BIT_TICKS == 1 ) |
There was a problem hiding this comment.
configTICK_TYPE_WIDTH_IN_BITS suggestion.
|
Kudos, SonarCloud Quality Gate passed!
|
Revert the formatting on CodeWarrior ports
Description
Revert the formatting on CodeWarrior ports
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.